Fabo/1573 sent errors via raven

CHANGELOG.md

@@ -31,6 +31,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 - [\#1564](https://github.com/cosmos/voyager/issues/1564) Add support to query governance proposals on `lcdClient(Mock).js` @fedekunze
 - [\#1544](https://github.com/cosmos/voyager/issues/1544) Added eslint-plugin-vue for cleaner vue files @jbibla
 - [\#1611](https://github.com/cosmos/voyager/issues/1611) added no testnet warning @faboweb
+- [\#1573](https://github.com/cosmos/voyager/issues/1573) added remote error collection for several catched errors in Voyager @faboweb
 
 ### Changed
 

app/src/renderer/vuex/modules/blockchain.js

@@ -1,3 +1,5 @@
+import Raven from "raven-js"
+
 export default ({ node }) => {
   const state = {
     blockMetaInfo: { block_id: {} },
@@ -65,6 +67,7 @@ export default ({ node }) => {
           title: `Error fetching block information`,
           body: err.message
         })
+        Raven.captureException(err)
         state.loading = false
         state.error = err
         return null

app/src/renderer/vuex/modules/connection.js

@@ -1,6 +1,5 @@
-"use strict"
-
 import { ipcRenderer, remote } from "electron"
+import Raven from "raven-js"
 import { sleep } from "scripts/common.js"
 
 const config = remote.getGlobal(`config`)
@@ -92,6 +91,7 @@ export default function({ node }) {
         { query: `tm.event = 'NewBlockHeader'` },
         (err, event) => {
           if (err) {
+            Raven.captureException(err)
             return console.error(`error subscribing to headers`, err)
           }
           dispatch(`setLastHeader`, event.data.value.header)
@@ -148,7 +148,11 @@ export default function({ node }) {
         }
       }, timeout)
       node.rpc.status(err => {
-        if (err) return console.error(`Couldn't get status via RPC:`, err)
+        if (err) {
+          Raven.captureException(err)
+          console.error(`Couldn't get status via RPC:`, err)
+          return
+        }
 
         state.nodeTimeout = null
         state.connected = true

app/src/renderer/vuex/modules/delegates.js

@@ -1,10 +1,10 @@
-"use strict"
-
+import Raven from "raven-js"
 import BN from "bignumber.js"
 import { ratToBigNumber } from "scripts/common"
 import num from "scripts/num"
 import { isEmpty } from "lodash"
 import b32 from "scripts/b32"
+
 export default ({ node }) => {
   const emptyState = {
     delegates: [],
@@ -100,6 +100,7 @@ export default ({ node }) => {
           title: `Error fetching validators`,
           body: err.message
         })
+        Raven.captureException(err)
         commit(`setDelegateLoading`, false)
         state.error = err
         return []

app/src/renderer/vuex/modules/delegation.js

@@ -1,6 +1,6 @@
-"use strict"
-
+import Raven from "raven-js"
 import { calculateShares } from "scripts/common"
+
 export default ({ node }) => {
   let emptyState = {
     loading: false,
@@ -145,6 +145,7 @@ export default ({ node }) => {
           title: `Error fetching delegations`,
           body: err.message
         })
+        Raven.captureException(err)
         state.error = err
       }
 

app/src/renderer/vuex/modules/filters.js

@@ -1,5 +1,3 @@
-"use strict"
-
 export default () => {
   const emptyState = {
     balances: {

app/src/renderer/vuex/modules/governance/deposits.js

@@ -1,4 +1,4 @@
-"use strict"
+import Raven from "raven-js"
 
 export default ({ node }) => {
   const state = {
@@ -24,6 +24,7 @@ export default ({ node }) => {
           title: `Error fetching deposits on proposals`,
           body: err.message
         })
+        Raven.captureException(err)
         state.error = err
       }
       state.loading = false

app/src/renderer/vuex/modules/governance/parameters.js

@@ -1,3 +1,5 @@
+import Raven from "raven-js"
+
 export default ({ node }) => {
   const emptyState = {
     govParameters: {
@@ -30,6 +32,7 @@ export default ({ node }) => {
           title: `Error fetching governance parameters`,
           body: err.message
         })
+        Raven.captureException(err)
         state.error = err
       }
       state.loading = false

app/src/renderer/vuex/modules/governance/proposals.js

@@ -1,4 +1,4 @@
-"use strict"
+import Raven from "raven-js"
 import Vue from "vue"
 
 export default ({ node }) => {
@@ -39,6 +39,7 @@ export default ({ node }) => {
           title: `Error fetching proposals`,
           body: err.message
         })
+        Raven.captureException(err)
         state.error = err
       }
       state.loading = false

app/src/renderer/vuex/modules/governance/votes.js

@@ -1,4 +1,4 @@
-"use strict"
+import Raven from "raven-js"
 
 export default ({ node }) => {
   const state = {
@@ -24,6 +24,7 @@ export default ({ node }) => {
           title: `Error fetching votes`,
           body: err.message
         })
+        Raven.captureException(err)
         state.error = err
       }
       state.loading = false

app/src/renderer/vuex/modules/keybase.js

@@ -1,4 +1,5 @@
 import axios from "axios"
+import Raven from "raven-js"
 
 export default ({}) => {
   const emptyState = {
@@ -57,6 +58,7 @@ export default ({}) => {
           title: `Error fetching keybase information for validators`,
           body: err.message
         })
+        Raven.captureException(err)
         state.error = err
       }
     }

app/src/renderer/vuex/modules/parameters.js

@@ -1,3 +1,5 @@
+import Raven from "raven-js"
+
 export default ({ node }) => {
   const emptyState = {
     parameters: {},
@@ -23,6 +25,7 @@ export default ({ node }) => {
           title: `Error fetching staking parameters`,
           body: err.message
         })
+        Raven.captureException(err)
         state.error = err
       }
       state.loading = false

app/src/renderer/vuex/modules/pool.js

@@ -1,4 +1,4 @@
-"use strict"
+import Raven from "raven-js"
 
 export default ({ node }) => {
   const emptyState = {
@@ -30,6 +30,7 @@ export default ({ node }) => {
           title: `Error fetching staking pool information`,
           body: err.message
         })
+        Raven.captureException(err)
         state.error = err
       }
       state.loading = false

app/src/renderer/vuex/modules/send.js

@@ -1,5 +1,3 @@
-"use strict"
-
 export default ({ node }) => {
   let lock = null
 

app/src/renderer/vuex/modules/transactions.js

@@ -1,5 +1,6 @@
-const fp = require(`lodash/fp`)
+import fp from "lodash/fp"
 import { uniqBy } from "lodash"
+import Raven from "raven-js"
 export default ({ node }) => {
   let emptyState = {
     loading: false,
@@ -26,9 +27,6 @@ export default ({ node }) => {
     setHistoryLoading(state, loading) {
       state.loading = loading
     },
-    setError(state, error) {
-      state.error = error
-    },
     setTransactionTime(state, { blockHeight, blockMetaInfo }) {
       txCategories.forEach(category => {
         state[category].forEach(t => {
@@ -50,10 +48,10 @@ export default ({ node }) => {
         await dispatch(`getAllTxs`)
       }
     },
-    async getAllTxs({ commit, dispatch }) {
-      commit(`setHistoryLoading`, true)
-
+    async getAllTxs({ commit, dispatch, state }) {
       try {
+        commit(`setHistoryLoading`, true)
+
         const stakingTxs = await dispatch(`getTx`, `staking`)
         commit(`setStakingTxs`, stakingTxs)
 
@@ -68,45 +66,39 @@ export default ({ node }) => {
           transactions: allTxs
         })
       } catch (error) {
-        commit(`setError`, error.message.slice(0))
+        commit(`notifyError`, {
+          title: `Error getting transactions`,
+          body: error.message
+        })
+        Raven.captureException(error)
+        state.error = error
       }
       commit(`setHistoryLoading`, false)
     },
     async getTx(
       {
         rootState: {
           user: { address }
-        },
-        commit
+        }
       },
       type
     ) {
-      try {
-        let response
-        switch (type) {
-          case `staking`:
-            response = await node.getDelegatorTxs(address)
-            break
-          case `governance`:
-            response = await node.getGovernanceTxs(address)
-            break
-          case `wallet`:
-            response = await node.txs(address)
-            break
-          default:
-            throw new Error(`Unknown transaction type`)
-        }
-        state.error = null
-        const transactionsPlusType = response.map(fp.set(`type`, type))
-        return response ? uniqBy(transactionsPlusType, `hash`) : []
-      } catch (err) {
-        commit(`notifyError`, {
-          title: `Error fetching ${type} transactions`,
-          body: err.message
-        })
-        state.error = err
-        return []
+      let response
+      switch (type) {
+        case `staking`:
+          response = await node.getDelegatorTxs(address)
+          break
+        case `governance`:
+          response = await node.getGovernanceTxs(address)
+          break
+        case `wallet`:
+          response = await node.txs(address)
+          break
+        default:
+          throw new Error(`Unknown transaction type`)
       }
+      const transactionsPlusType = response.map(fp.set(`type`, type))
+      return response ? uniqBy(transactionsPlusType, `hash`) : []
     },
     async enrichTransactions({ dispatch }, { transactions }) {
       const blockHeights = new Set(transactions.map(({ height }) => height))

app/src/renderer/vuex/modules/user.js

@@ -1,8 +1,6 @@
-"use strict"
-
-import enableGoogleAnalytics from "../../google-analytics.js"
 import Raven from "raven-js"
-const { ipcRenderer, remote } = require(`electron`)
+import { ipcRenderer, remote } from "electron"
+import enableGoogleAnalytics from "../../google-analytics.js"
 const config = remote.getGlobal(`config`)
 
 export default ({ node }) => {
@@ -18,7 +16,8 @@ export default ({ node }) => {
     account: null,
     address: null,
     errorCollection: false,
-    stateLoaded: false // shows if the persisted state is already loaded. used to prevent overwriting the persisted state before it is loaded
+    stateLoaded: false, // shows if the persisted state is already loaded. used to prevent overwriting the persisted state before it is loaded
+    error: null
   }
 
   const mutations = {
@@ -61,15 +60,20 @@ export default ({ node }) => {
           dl: `/session/` + screen
         })
     },
-    async loadAccounts({ commit }) {
+    async loadAccounts({ commit, state }) {
+      state.loading = true
       try {
         let keys = await node.keys.values()
         commit(`setAccounts`, keys)
       } catch (err) {
+        Raven.captureException(err)
         commit(`notifyError`, {
           title: `Couldn't read keys`,
           body: err.message
         })
+        state.error = err
+      } finally {
+        state.loading = false
       }
     },
     async testLogin(state, { password, account }) {

app/src/renderer/vuex/modules/validators.js

@@ -1,4 +1,4 @@
-"use strict"
+import Raven from "raven-js"
 
 export default ({ node }) => {
   const emptyState = {
@@ -39,6 +39,7 @@ export default ({ node }) => {
           title: `Error fetching validator set`,
           body: err.message
         })
+        Raven.captureException(err)
         state.error = err
       }
       state.loading = false