Jordan+Fabo/1626 update sentry #1731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
so it seems that the new sentry SDK has improved support for source maps - having a hard time understanding this documentation tbh.
|
|
That looks awesome! |
sabau
reviewed
Dec 11, 2018
app/src/main/index.js
Outdated
| if (optin) { | ||
| Sentry.init({ | ||
| dsn: config.sentry_dsn, | ||
| release: `[email protected]` |
There was a problem hiding this comment.
Yeah it's WIP but I was curious :)
If you want to forget aligning this with package.json we can do something like
import {version} from './package.json';There was a problem hiding this comment.
good idea. will fix.
Codecov Report
@@ Coverage Diff @@
## develop #1731 +/- ##
==========================================
- Coverage 97.74% 97.7% -0.05%
==========================================
Files 102 102
Lines 2086 2090 +4
Branches 93 93
==========================================
+ Hits 2039 2042 +3
- Misses 38 39 +1
Partials 9 9
|
Codecov Report
@@ Coverage Diff @@
## develop #1731 +/- ##
==========================================
- Coverage 97.74% 97.7% -0.05%
==========================================
Files 102 102
Lines 2086 2093 +7
Branches 93 93
==========================================
+ Hits 2039 2045 +6
- Misses 38 39 +1
Partials 9 9
|
faboweb
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1626
Description:
❤️ Thank you!
CHANGELOG.mdwith issue # and GitHub usernameFiles changedin the github PR explorer