-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jordan+Fabo/1626 update sentry #1731
Merged
Merged
Changes from 2 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
f1a9ec9
upgrade from raven to sentry/browser
jbibla 8c359f2
changelog
jbibla bb340fe
linted
e3690ad
fixed integration tests
fbf0070
fixed tests
f7379e7
Merge remote-tracking branch 'origin/develop' into jordan/1626-update…
37cc16e
fixed wallet tests
e10d72d
fixed e2e tests
1a36d17
removed forced error
ebf2c4f
fixed bug with not being able to signup
76432ab
Merge branch 'develop' into jordan/1626-update-sentry
fedekunze File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,7 +7,7 @@ const https = require(`https`) | |
let { join, relative } = require(`path`) | ||
let childProcess = require(`child_process`) | ||
let semver = require(`semver`) | ||
let Raven = require(`raven`) | ||
const Sentry = require("@sentry/node") | ||
const readline = require(`readline`) | ||
let axios = require(`axios`) | ||
|
||
|
@@ -222,7 +222,7 @@ function startProcess(name, args, env) { | |
console.error(...errorMessage) // also output to console for easier debugging | ||
handleCrash(error) | ||
|
||
Raven.captureException(error) | ||
Sentry.captureException(error) | ||
} | ||
}) | ||
|
||
|
@@ -382,12 +382,12 @@ if (!TEST) { | |
// on uncaught exceptions we wait so the sentry event can be sent | ||
process.on(`uncaughtException`, async function(error) { | ||
logError(`[Uncaught Exception]`, error) | ||
Raven.captureException(error) | ||
Sentry.captureException(error) | ||
handleCrash(error) | ||
}) | ||
process.on(`unhandledRejection`, async function(error) { | ||
logError(`[Unhandled Promise Rejection]`, error) | ||
Raven.captureException(error) | ||
Sentry.captureException(error) | ||
handleCrash(error) | ||
}) | ||
} | ||
|
@@ -399,11 +399,13 @@ const eventHandlers = { | |
}, | ||
|
||
"error-collection": (event, optin) => { | ||
Raven.uninstall() | ||
.config(optin ? config.sentry_dsn : ``, { | ||
captureUnhandledRejections: false | ||
if (optin) { | ||
Sentry.init({ | ||
dsn: config.sentry_dsn, | ||
release: `[email protected]` | ||
}) | ||
.install() | ||
Sentry.captureException(new Error("Good bye")) | ||
} | ||
}, | ||
|
||
mocked: value => { | ||
|
@@ -595,8 +597,12 @@ const checkGaiaCompatibility = async gaiacliVersionPath => { | |
} | ||
|
||
async function main() { | ||
// we only enable error collection after users opted in | ||
Raven.config(``, { captureUnhandledRejections: false }).install() | ||
// Sentry is used for automatic error reporting. It is turned off by default. | ||
Sentry.init({ | ||
dsn: config.sentry_dsn, | ||
release: `[email protected]` | ||
}) | ||
Sentry.captureException(new Error("TESTING SENTRY")) | ||
|
||
let appVersionPath = join(root, `app_version`) | ||
let genesisPath = join(root, `genesis.json`) | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah it's WIP but I was curious :)
If you want to forget aligning this with package.json we can do something like
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good idea. will fix.