-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor LurkField with lurk_ff changes #239
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: porcuquine <[email protected]>
* Implement coercion to u32 (and to char) --------- Co-authored-by: porcuquine <[email protected]>
johnchandlerburnham
requested review from
emmorais and
porcuquine
as code owners
February 1, 2023 00:41
This was referenced Feb 1, 2023
porcuquine
reviewed
Feb 2, 2023
porcuquine
reviewed
Feb 2, 2023
porcuquine
reviewed
Feb 2, 2023
porcuquine
reviewed
Feb 2, 2023
porcuquine
reviewed
Feb 2, 2023
porcuquine
reviewed
Feb 2, 2023
porcuquine
reviewed
Feb 2, 2023
porcuquine
approved these changes
Feb 8, 2023
porcuquine
approved these changes
Feb 8, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactor supersedes the
lurk_ff
crate from #191.The essential pieces of this are:
src/tag.rs
, sincesrc.store.rs
has way too much stuff in it.Tag
aswhich in turn allows for refactoring Ptr/ContPtr/ScalarPtr/ScalarContPtr.
This PR includes #237, which should be merged first.