Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor LurkField with lurk_ff changes #239

Merged
merged 20 commits into from
Feb 8, 2023
Merged

Refactor LurkField with lurk_ff changes #239

merged 20 commits into from
Feb 8, 2023

Conversation

johnchandlerburnham
Copy link
Contributor

This refactor supersedes the lurk_ff crate from #191.

The essential pieces of this are:

  • move tagging enums to src/tag.rs, since src.store.rs has way too much stuff in it.
  • Improving various conversion functions for tags and fields
  • adding some utilities which will be needed for serialization later
  • Rename Tag -> ExprTag. This is needed because subsequent changes will require defining Tag as
enum Tag {
 Expr(ExprTag),
 Cont(ContTag),
 Op1(Op1),
 Op2(Op2),
}

which in turn allows for refactoring Ptr/ContPtr/ScalarPtr/ScalarContPtr.

This PR includes #237, which should be merged first.

src/field.rs Outdated Show resolved Hide resolved
src/field.rs Outdated Show resolved Hide resolved
src/field.rs Outdated Show resolved Hide resolved
src/field.rs Outdated Show resolved Hide resolved
src/field.rs Outdated Show resolved Hide resolved
src/store.rs Outdated Show resolved Hide resolved
@porcuquine porcuquine merged commit e539cf4 into master Feb 8, 2023
@porcuquine porcuquine deleted the jcb/lurk_ff branch February 8, 2023 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants