LurkField + refactor quickcheck -> proptest #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: porcuquine <[email protected]>
* Implement coercion to u32 (and to char) --------- Co-authored-by: porcuquine <[email protected]>
johnchandlerburnham
requested review from
emmorais and
porcuquine
as code owners
This was referenced Feb 1, 2023
johnchandlerburnham
changed the title
johnchandlerburnham
changed the title
|
This seems fine to me. Once #239 merges, we could also merge this to master (base branch should change on merge) with @huitseeker's approval. |
huitseeker
approved these changes
Feb 8, 2023
There was a problem hiding this comment.
This is ok in the sense that it’s a conservative tweak of #229, so I’m of course very positive on getting this in, modulo the tweak on the Arbitrary for field elements (which I trust @johnchandlerburnham to fix before merge).
The next missing step is to better exploit derivation of Arbitrary, but we can definitely do that in a second pass.
|
Looks like we have an issue with the WASM build that just got merged, because proptest doesn't compile to WASM: proptest-rs/proptest#137 |
porcuquine
approved these changes
Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges #229 on top of #239, which changes some details of what #229 tests