Replace hardcoded default colors with defaults in setupColors.js (apa…

…che#8510)
lyft · Nov 7, 2019 · 397e1e3 · 397e1e3
1 parent ec476fc
commit 397e1e3
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/superset/assets/src/explore/controls.jsx b/superset/assets/src/explore/controls.jsx
@@ -375,7 +375,7 @@ export const controls = {
     choices: () => sequentialSchemeRegistry
       .values()
       .map(value => [value.id, value.label]),
-    default: 'blue_white_yellow',
+    default: sequentialSchemeRegistry.getDefaultKey(),
     clearable: false,
     description: '',
     renderTrigger: true,
@@ -2066,7 +2066,7 @@ export const controls = {
   color_scheme: {
     type: 'ColorSchemeControl',
     label: t('Color Scheme'),
-    default: 'bnbColors',
+    default: categoricalSchemeRegistry.getDefaultKey(),
     renderTrigger: true,
     choices: () => categoricalSchemeRegistry.keys().map(s => ([s, s])),
     description: t('The color scheme for rendering chart'),

diff --git a/superset/assets/src/setup/setupColors.js b/superset/assets/src/setup/setupColors.js
@@ -40,4 +40,5 @@ export default function setupColors() {
       sequentialSchemeRegistry.registerValue(scheme.id, scheme);
     });
   });
+  sequentialSchemeRegistry.setDefaultKey('blue_white_yellow');
 }
-Original file line number
+Diff line change
@@ Expand Up / @@ -40,4 +40,5 @@ export default function setupColors() { @@
           sequentialSchemeRegistry.registerValue(scheme.id, scheme);
         });
       });
+      sequentialSchemeRegistry.setDefaultKey('blue_white_yellow');
     }