This repository has been archived by the owner on Apr 8, 2019. It is now read-only.
Add multi worker pool #181
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #181 +/- ##
==========================================
+ Coverage 78.19% 78.27% +0.08%
==========================================
Files 86 87 +1
Lines 3518 3531 +13
==========================================
+ Hits 2751 2764 +13
Misses 699 699
Partials 68 68Continue to review full report at Codecov.
|
martin-mao
approved these changes
Jun 6, 2018
|
|
||
| type multiWorkerPool struct { | ||
| poolCh chan WorkerPool | ||
| poolSize int |
There was a problem hiding this comment.
Nit: Call this inner pool size as not to confuse whether you're referring to how many pools are in the multi pool.
|
This may not be necessary, Object pool should be sufficient for what's required, and the cast isn't incurring too bad a cost. |
|
Closing this as it's not necessary for the current applications |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.