This repository has been archived by the owner on Apr 8, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3
Add multi worker pool #181
Closed
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,65 @@ | ||
// Copyright (c) 2018 Uber Technologies, Inc. | ||
// | ||
// Permission is hereby granted, free of charge, to any person obtaining a copy | ||
// of this software and associated documentation files (the "Software"), to deal | ||
// in the Software without restriction, including without limitation the rights | ||
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
// copies of the Software, and to permit persons to whom the Software is | ||
// furnished to do so, subject to the following conditions: | ||
// | ||
// The above copyright notice and this permission notice shall be included in | ||
// all copies or substantial portions of the Software. | ||
// | ||
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN | ||
// THE SOFTWARE. | ||
|
||
// Package sync implements synchronization facililites such as worker pools. | ||
package sync | ||
|
||
// MultiWorkerPool provides a pool for WorkerPools. This can be useful if multiple | ||
// independent processes need to share a set amount of pools, but with bounding conditions | ||
// as to how many workers a single process can consume | ||
type MultiWorkerPool interface { | ||
// Init initializes the pool. | ||
Init() | ||
|
||
// GetPool provides a WorkerPool | ||
GetPool() WorkerPool | ||
|
||
// PutPool returns a WorkerPool to the pool | ||
PutPool(pool WorkerPool) | ||
} | ||
|
||
type multiWorkerPool struct { | ||
poolCh chan WorkerPool | ||
poolSize int | ||
} | ||
|
||
// NewMultiWorkerPool creates a new multi worker pool. | ||
func NewMultiWorkerPool(size int, poolSize int) MultiWorkerPool { | ||
return &multiWorkerPool{ | ||
poolCh: make(chan WorkerPool, size), | ||
poolSize: poolSize, | ||
} | ||
} | ||
|
||
func (p *multiWorkerPool) Init() { | ||
for i := 0; i < cap(p.poolCh); i++ { | ||
innerPool := NewWorkerPool(p.poolSize) | ||
innerPool.Init() | ||
p.poolCh <- innerPool | ||
} | ||
} | ||
|
||
func (p *multiWorkerPool) GetPool() WorkerPool { | ||
return <-p.poolCh | ||
} | ||
|
||
func (p *multiWorkerPool) PutPool(pool WorkerPool) { | ||
p.poolCh <- pool | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,60 @@ | ||
// Copyright (c) 2017 Uber Technologies, Inc. | ||
// | ||
// Permission is hereby granted, free of charge, to any person obtaining a copy | ||
// of this software and associated documentation files (the "Software"), to deal | ||
// in the Software without restriction, including without limitation the rights | ||
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
// copies of the Software, and to permit persons to whom the Software is | ||
// furnished to do so, subject to the following conditions: | ||
// | ||
// The above copyright notice and this permission notice shall be included in | ||
// all copies or substantial portions of the Software. | ||
// | ||
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN | ||
// THE SOFTWARE. | ||
|
||
package sync | ||
|
||
import ( | ||
"sync" | ||
"sync/atomic" | ||
"testing" | ||
|
||
"github.com/stretchr/testify/require" | ||
) | ||
|
||
const multiTestWorkerPoolSize = 2 | ||
|
||
func TestGetRoutine(t *testing.T) { | ||
var count uint32 | ||
|
||
multi := NewMultiWorkerPool(multiTestWorkerPoolSize, testWorkerPoolSize) | ||
multi.Init() | ||
|
||
var multiWg sync.WaitGroup | ||
for pool := 0; pool < multiTestWorkerPoolSize*2; pool++ { | ||
multiWg.Add(1) | ||
go func() { | ||
p := multi.GetPool() | ||
var wg sync.WaitGroup | ||
for i := 0; i < testWorkerPoolSize*2; i++ { | ||
wg.Add(1) | ||
p.Go(func() { | ||
atomic.AddUint32(&count, 1) | ||
wg.Done() | ||
}) | ||
} | ||
wg.Wait() | ||
multi.PutPool(p) | ||
multiWg.Done() | ||
}() | ||
} | ||
multiWg.Wait() | ||
|
||
require.Equal(t, uint32(testWorkerPoolSize*2*multiTestWorkerPoolSize*2), count) | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Call this inner pool size as not to confuse whether you're referring to how many pools are in the multi pool.