Resolve clippy lints #225
Merged
Resolve clippy lints #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 19, 2020 14:02
warning: unnecessary parentheses around assigned value
--> src/mach/constants.rs:222:42
|
222 | pub const CPU_TYPE_X86_64: CpuType = (CPU_TYPE_X86 | CPU_ARCH_ABI64);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses
|
= note: `#[warn(unused_parens)]` on by default
warning: unnecessary parentheses around assigned value
--> src/mach/constants.rs:227:41
|
227 | pub const CPU_TYPE_ARM64: CpuType = (CPU_TYPE_ARM | CPU_ARCH_ABI64);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses
warning: unnecessary parentheses around assigned value
--> src/mach/constants.rs:228:44
|
228 | pub const CPU_TYPE_ARM64_32: CpuType = (CPU_TYPE_ARM | CPU_ARCH_ABI64_32);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses
warning: unnecessary parentheses around assigned value
--> src/mach/constants.rs:234:45
|
234 | pub const CPU_TYPE_POWERPC64: CpuType = (CPU_TYPE_POWERPC | CPU_ARCH_ABI64);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses
warning: this import is redundant --> src/error.rs:7:1 | 7 | use scroll; | ^^^^^^^^^^^ help: remove it entirely | = note: `#[warn(clippy::single_component_path_imports)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports warning: this import is redundant --> src/lib.rs:114:5 | 114 | use scroll; | ^^^^^^^^^^^ help: remove it entirely | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports
warning: this import is redundant
--> src/elf/program_header.rs:376:5
|
376 | use plain;
| ^^^^^^^^^^ help: remove it entirely
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports
warning: this import is redundant
--> src/elf/program_header.rs:411:5
|
411 | use plain;
| ^^^^^^^^^^ help: remove it entirely
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports
m4b
approved these changes
Jul 26, 2020
| @@ -111,7 +111,6 @@ pub mod strtab; | |||
|
|
|||
| /// Binary container size information and byte-order context | |||
| pub mod container { | |||
| use scroll; | |||
There was a problem hiding this comment.
interesting how come this and above use aren't warnings?
| pub const CPU_TYPE_MIPS: CpuType = 8; | ||
| pub const CPU_TYPE_MC98000: CpuType = 10; | ||
| pub const CPU_TYPE_HPPA: CpuType = 11; | ||
| pub const CPU_TYPE_ARM: CpuType = 12; | ||
| pub const CPU_TYPE_ARM64: CpuType = (CPU_TYPE_ARM | CPU_ARCH_ABI64); | ||
| pub const CPU_TYPE_ARM64_32: CpuType = (CPU_TYPE_ARM | CPU_ARCH_ABI64_32); |
There was a problem hiding this comment.
i'm surprised this isn't a warning either
|
@connorkuehl So i squashed the commits, and removed the clippy warnings from message; i've merged some like this before, but i don't think its super useful (although it was useful to me when i reviewed it, maybe thats a point for keeping them). Anyway, hope you don't mind, and thanks for the PR and sorry for such late merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry if this PR is just noise, but I saw some other commits cleaning clippy warnings up.
I'm happy to squash this into 1 commit too, if that's the preference.
edit: the clippy output is saved in each commit