Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve clippy lints #225

Merged
merged 3 commits into from
Jul 26, 2020
Merged

Resolve clippy lints #225

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e137acc
mach.constants: Resolve clippy lints
May 19, 2020
c9c4a34
crate: Resolve clippy lints
May 19, 2020
b9c20b4
elf: Resolve clippy lints
May 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/elf/program_header.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,7 +373,6 @@ pub mod program_header32 {

pub const SIZEOF_PHDR: usize = 32;

use plain;
// Declare that this is a plain type.
unsafe impl plain::Plain for ProgramHeader {}

Expand Down Expand Up @@ -408,7 +407,6 @@ pub mod program_header64 {

pub const SIZEOF_PHDR: usize = 56;

use plain;
// Declare that this is a plain type.
unsafe impl plain::Plain for ProgramHeader {}

Expand Down
1 change: 0 additions & 1 deletion src/error.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
use alloc::string::String;
use core::fmt;
use core::result;
use scroll;
#[cfg(feature = "std")]
use std::{error, io};

Expand Down
1 change: 0 additions & 1 deletion src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,6 @@ pub mod strtab;

/// Binary container size information and byte-order context
pub mod container {
use scroll;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting how come this and above use aren't warnings?

pub use scroll::Endian;

#[derive(Debug, Copy, Clone, PartialEq)]
Expand Down
8 changes: 4 additions & 4 deletions src/mach/constants.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,19 +219,19 @@ pub mod cputype {
pub const CPU_TYPE_MC680X0: CpuType = 6;
pub const CPU_TYPE_X86: CpuType = 7;
pub const CPU_TYPE_I386: CpuType = CPU_TYPE_X86;
pub const CPU_TYPE_X86_64: CpuType = (CPU_TYPE_X86 | CPU_ARCH_ABI64);
pub const CPU_TYPE_X86_64: CpuType = CPU_TYPE_X86 | CPU_ARCH_ABI64;
pub const CPU_TYPE_MIPS: CpuType = 8;
pub const CPU_TYPE_MC98000: CpuType = 10;
pub const CPU_TYPE_HPPA: CpuType = 11;
pub const CPU_TYPE_ARM: CpuType = 12;
pub const CPU_TYPE_ARM64: CpuType = (CPU_TYPE_ARM | CPU_ARCH_ABI64);
pub const CPU_TYPE_ARM64_32: CpuType = (CPU_TYPE_ARM | CPU_ARCH_ABI64_32);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm surprised this isn't a warning either

pub const CPU_TYPE_ARM64: CpuType = CPU_TYPE_ARM | CPU_ARCH_ABI64;
pub const CPU_TYPE_ARM64_32: CpuType = CPU_TYPE_ARM | CPU_ARCH_ABI64_32;
pub const CPU_TYPE_MC88000: CpuType = 13;
pub const CPU_TYPE_SPARC: CpuType = 14;
pub const CPU_TYPE_I860: CpuType = 15;
pub const CPU_TYPE_ALPHA: CpuType = 16;
pub const CPU_TYPE_POWERPC: CpuType = 18;
pub const CPU_TYPE_POWERPC64: CpuType = (CPU_TYPE_POWERPC | CPU_ARCH_ABI64);
pub const CPU_TYPE_POWERPC64: CpuType = CPU_TYPE_POWERPC | CPU_ARCH_ABI64;

// CPU Subtypes
pub const CPU_SUBTYPE_MULTIPLE: CpuSubType = !0;
Expand Down