Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodejs*: drop nodejs{5,7,9} #4113

Merged
merged 1 commit into from
Apr 25, 2019
Merged

nodejs*: drop nodejs{5,7,9} #4113

merged 1 commit into from
Apr 25, 2019

Conversation

yan12125
Copy link
Contributor

Description

Those versions are non-LTS and have reached their end-of-life [1].

Closes: https://trac.macports.org/ticket/53799
Closes: https://trac.macports.org/ticket/54083
Closes: https://trac.macports.org/ticket/55655
Closes: https://trac.macports.org/ticket/55656

I don't think there's a node.js package compatible with a non-LTS version but none of LTS versions. I don't touch nodejs 4 as newer nodejs versions does not work on 10.6 [2].

[1] https://github.com/nodejs/Release
[2] https://trac.macports.org/ticket/53166

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

Not tested

Verification

Have you

@macportsbot
Copy link

Notifying maintainers:
@ci42 for port nodejs10, nodejs11, nodejs4, nodejs5, nodejs6, nodejs7, nodejs8, nodejs9.

@macportsbot macportsbot added by: member Created by a member with commit rights maintainer: requires approval labels Apr 21, 2019
@yan12125 yan12125 mentioned this pull request Apr 21, 2019
25 tasks
@macportsbot
Copy link

Travis Build #6037 Errored.

Lint results
--->  Verifying Portfile for nodejs10
Error: Line 91 uses compiler.blacklist entry {clang < 800} which requires the compiler_blacklist_versions portgroup which has not been included
--->  1 errors and 0 warnings found.
--->  Verifying Portfile for nodejs11
Error: Line 90 uses compiler.blacklist entry {clang < 800} which requires the compiler_blacklist_versions portgroup which has not been included
--->  1 errors and 0 warnings found.
--->  Verifying Portfile for nodejs4
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for nodejs5
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for nodejs6
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for nodejs7
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for nodejs8
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for nodejs9
--->  0 errors and 0 warnings found.

The build timed out.

@kencu
Copy link
Contributor

kencu commented Apr 22, 2019

If you wouldn't mind terribly, I would appreciate a few days to see which of these is the actual latest version that 10.6.8 can support.

So much has changed with the legacysupport PG and libc++ that these older ideas of what is compatible with what might no longer be actually true...

@yan12125
Copy link
Contributor Author

Sorry, I don't have enough disk space to maintain a 10.6 VM :(

@kencu
Copy link
Contributor

kencu commented Apr 22, 2019

looks like many of the even numbered maintenance versions do build on older systems, so feel free to bin these defunct versions from my point of view.

@l2dy
Copy link
Member

l2dy commented Apr 25, 2019

Maintainer timeout! I also agree with removing non-LTS versions, so I'm going to merge this now. Thanks for your contribution.

@l2dy l2dy merged commit 08408fd into macports:master Apr 25, 2019
@yan12125 yan12125 deleted the drop-old-nodejs branch April 25, 2019 11:49
@yan12125
Copy link
Contributor Author

Thanks for looking into this PR. With awesome efforts in #4119, I guess nodejs 4 can be dropped, too. Will do that in another PR.

@yan12125 yan12125 mentioned this pull request Apr 28, 2019
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

5 participants