Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop nodejs4 #4197

Merged
merged 5 commits into from
May 2, 2019
Merged

Drop nodejs4 #4197

merged 5 commits into from
May 2, 2019

Conversation

yan12125
Copy link
Contributor

Description

This is a follow-up of #4113.

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

Not tested

Verification

Have you

@macportsbot
Copy link

Notifying maintainers:
@jambonrose for port yarn.
@ryandesign for port jake.
@ci42 for port nodejs10, nodejs11, nodejs4, nodejs6, nodejs8, npm2, npm3, npm4.
@dylanbr for port npm5.
@l2dy for port npm6.
@isomarcte for port yarn.

@macportsbot macportsbot added by: member Created by a member with commit rights maintainer: requires approval labels Apr 28, 2019
@yan12125
Copy link
Contributor Author

Just saw an old ticket https://trac.macports.org/ticket/51753

Probably we should just remove any such ports that were already added (jake, coffee-script, anything using those ports).

@ryandesign: Do you want me to remove jake instead of updating it in this PR?

@macportsbot
Copy link

Travis Build #6172 Errored.

Lint results 
--->  Verifying Portfile for jake
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for nodejs10
Error: Line 91 uses compiler.blacklist entry {clang < 800} which requires the compiler_blacklist_versions portgroup which has not been included
--->  1 errors and 0 warnings found.
--->  Verifying Portfile for nodejs11
Error: Line 90 uses compiler.blacklist entry {clang < 800} which requires the compiler_blacklist_versions portgroup which has not been included
--->  1 errors and 0 warnings found.
--->  Verifying Portfile for nodejs4
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for nodejs6
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for nodejs8
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for npm2
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for npm3
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for npm4
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for npm5
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for npm6
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for yarn
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for nodejuice
--->  0 errors and 0 warnings found.

Port jake fail on xcode10.2. Log
Port nodejs10 success on xcode10.2. Log
Port jake fail on xcode9.4. Log
Port nodejs10 success on xcode9.4. Log
Port jake fail on xcode8.3. Log
Port nodejs10 success on xcode8.3. Log
Port jake's dependencies fail on xcode7.3. Log
Port nodejs10's dependencies fail on xcode7.3. Log
Port nodejs11's dependencies fail on xcode7.3. Log
Port nodejs6's dependencies fail on xcode7.3. Log
Port nodejs8's dependencies fail on xcode7.3. Log
Port npm3's dependencies fail on xcode7.3. Log
Port npm4's dependencies fail on xcode7.3. Log
Port npm5's dependencies fail on xcode7.3. Log
Port npm6's dependencies fail on xcode7.3. Log
Port yarn's dependencies fail on xcode7.3. Log
Port nodejuice's dependencies fail on xcode7.3. Log

The build timed out.

@macportsbot
Copy link

Travis Build #6173 Errored.

Lint results 
--->  Verifying Portfile for jake
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for nodejs10
Error: Line 91 uses compiler.blacklist entry {clang < 800} which requires the compiler_blacklist_versions portgroup which has not been included
--->  1 errors and 0 warnings found.
--->  Verifying Portfile for nodejs11
Error: Line 90 uses compiler.blacklist entry {clang < 800} which requires the compiler_blacklist_versions portgroup which has not been included
--->  1 errors and 0 warnings found.
--->  Verifying Portfile for nodejs4
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for nodejs6
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for nodejs8
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for npm2
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for npm3
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for npm4
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for npm5
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for npm6
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for yarn
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for nodejuice
--->  0 errors and 0 warnings found.

Port jake success on xcode10.2. Log
Port nodejs10 success on xcode10.2. Log
Port jake success on xcode9.4. Log
Port nodejs10 success on xcode9.4. Log
Port jake success on xcode8.3. Log
Port nodejs10 success on xcode8.3. Log
Port jake success on xcode7.3. Log
Port nodejs10 success on xcode7.3. Log

The build timed out.

Chih-Hsuan Yen added 5 commits April 29, 2019 10:14
nodejs*: Drop nodejs4
f9543f6 
Node.js 4.x had reached end-of-life roughly a year ago [1]. It was kept
is it was the latest Node.js version working on Mac OS X 10.6. Now
nodejs6 also works on 10.6 (thanks to kencu! [2]), there's no need to
keep nodejs4 around.

[1] https://github.com/nodejs/Release
[2] #4119
npm*: drop npm2 and switch to nodejs6 for older systems
507615f 
npm supports versions that are still shipped with maintained Node.js
versions [1]. Currently Node.js 6.x ships npm 3.x [2]. As nodejs4 is to
be dropped, there's no need to keep npm2 around.

[1] https://github.com/npm/cli/wiki/LTS
[2] https://github.com/nodejs/node/blob/v6.x/deps/npm/package.json
yarn: switch to nodejs6 for older systems
37d0614
jake: update to 8.1.1 and use new Node.js versions
5940fbd 
This version support Node.js 6.x to 10.x [1]

[1] https://github.com/jakejs/jake/blob/v8.1.1/.travis.yml
nodejuice: switch to nodejs6
b5c1e48 
Running ./nodejuice with nodejs6 appears to be fine. Not switching to
newer Node.js versions as upstream git repo has been inactive since
2012 [1].

[1] https://github.com/stephenlb/nodejuice/commits/master
@yan12125
Copy link
Contributor Author

Rebased to master for addition of nodejs12.

@macportsbot
Copy link

Travis Build #6177 Errored.

Lint results 
--->  Verifying Portfile for jake
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for nodejs10
Error: Line 91 uses compiler.blacklist entry {clang < 800} which requires the compiler_blacklist_versions portgroup which has not been included
--->  1 errors and 0 warnings found.
--->  Verifying Portfile for nodejs11
Error: Line 91 uses compiler.blacklist entry {clang < 800} which requires the compiler_blacklist_versions portgroup which has not been included
--->  1 errors and 0 warnings found.
--->  Verifying Portfile for nodejs12
Error: Line 88 uses compiler.blacklist entry {clang < 800} which requires the compiler_blacklist_versions portgroup which has not been included
--->  1 errors and 0 warnings found.
--->  Verifying Portfile for nodejs4
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for nodejs6
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for nodejs8
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for npm2
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for npm3
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for npm4
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for npm5
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for npm6
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for yarn
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for nodejuice
--->  0 errors and 0 warnings found.

Port jake success on xcode10.2. Log
Port nodejs10 success on xcode10.2. Log
Port jake success on xcode9.4. Log
Port nodejs10 success on xcode9.4. Log
Port jake success on xcode8.3. Log
Port nodejs10 success on xcode8.3. Log
Port jake success on xcode7.3. Log
Port nodejs10 success on xcode7.3. Log

The build timed out.

@yan12125
Copy link
Contributor Author

yan12125 commented May 2, 2019

@ci42 Any comments? Given the maintainer timeout policy, I can merge this by myself, but I still want feedback for commits dropping ports.

@ci42
Copy link
Contributor

ci42 commented May 2, 2019

@yan12125 LGTM

@yan12125
Copy link
Contributor Author

yan12125 commented May 2, 2019

Great! Gonna merge.

@yan12125 yan12125 merged commit 9b21453 into macports:master May 2, 2019
@yan12125 yan12125 deleted the drop-nodejs4 branch May 2, 2019 06:38
@yan12125 yan12125 mentioned this pull request May 4, 2019
Merged
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ryandesign ryandesign

@ci42 ci42

@l2dy l2dy

Labels
by: member Created by a member with commit rights maintainer: requires approval maintainer: timeout
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yan12125 @macportsbot @ci42 @ryandesign @l2dy