SourceMap: Independent of settings. #833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The aim is to make source-map generation independent of WE's "generate .map" settings for LESS and SCSS.. It will compile just once on document open (which it already does); if the map generation is set, read from the generated map file. Otherwise, in compiler parameter we set path to temp file, read all text and delete the file.
In scenarios like sel1 > sel2 + sel3, the CSS parser attach `+` and `>` signs to the previous selector, while CSS source map count it with the current node (SimpleSelector; that is part of selector).
madskristensen
added a commit
that referenced
this pull request
Apr 2, 2014
SourceMap: Independent of settings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SourceMap independence from settings
The aim is to make source-map generation
independent of WE's "generate .map" settings
for LESS and SCSS..
It will compile just once on document open (which
it already does); if the map generation is set,
read from the generated map file. Otherwise,
in compiler parameter we set path to temp file,
read all text and delete the file.
Go To Definition:
In scenarios like
selector1 > selector2 + selector3,the CSS parser attach
+and>signs to the prevselector, while CSS source map count it with the
current node (SimpleSelector; part of selector).
This PR also fixes those scenarios for LESS.