LESS: Prevent the reference to the css.map

[gcastre]

LESS: Prevent the reference to the css.map in the css result if the option is disabled

If you disable the source map generation from less the css has the reference to the css.map.
This happen because of the change in am11@5a826c7 removing the check to WESettings.Instance.Less.GenerateSourceMaps before adding the --source-map-basepath=\"{0}\" --source-map=\"{1}\" to the less compiler command line.

[am11]

This is wrong; see this #833. Its part of making map file generation independent of settings (for editor enhancement features; CSS specificity, Go To Definition and getting full selector path to show in the tooltip).

If the map file option is set, it will keep, otherwise delete the map file after parsing via CssSourceMap.

So please add this code:

if (!GenerateSourceMap)
    File.Delete(MapFileName);

after ExecutorBase.cs Line 75.

and rebase. I missed it between the commits and rebasing.

BTW, this functionality goes for both LESS and SCSS.

[gcastre]

I'm not talking about generating .css.map files (it works fine for me with the current 2.0). I'm talking about having now in *.css files the

/*# sourceMappingURL=site.css.map */ reference even with the .css.map disable...

[am11]

Yes this will happen because we are generating maps for all cases. Source-map comment is something we should handle in post processing phase, without changing the compiler switches.

On that note, we can use ReadAllLines and then WriteAllLines minus the last one. The post-processing step happens in CssCompilerBase class.

[am11]

This is fixed by am11@c058263 via #849.

@madskristensen, #849 fixes this issue. This needs to be closed without merging.