Skip to content
This repository has been archived by the owner on Apr 29, 2019. It is now read-only.

mcrypt removed from PHP 7.2 core #10

Closed
buskamuza opened this issue Dec 22, 2017 · 4 comments
Closed

mcrypt removed from PHP 7.2 core #10

buskamuza opened this issue Dec 22, 2017 · 4 comments
Assignees
@igrybkov
Labels
backward-incompatible blocker investigation-needed requires-ee-changes

Comments

@buskamuza
Copy link
Contributor

buskamuza commented Dec 22, 2017 •
edited
Loading

Important: Use libs-upgrade branch as base for this task and as target for the PR.

Investigate possible solutions.

Options:

  1. use sodium
  2. use mcrypt_compat lib
  3. require PECL installation of mcrypt
  4. Other

Design document - https://github.com/magento-engcom/php-7.2-support/wiki/HLD---Removing-mcrypt-and-adding-libsodium
@buskamuza
Copy link
Contributor Author

Note ready for work yet. Requires investigation of which library to use.

@buskamuza
Copy link
Contributor Author

In case of moving to Sodium:

  • Couple framework encryption interfaces which should be reimplemented
  • magento/zf1 usages must be adjusted
  • A lot of usages in 3rd party libraries, compatible versions existence must be checked

@giabmf11 giabmf11 self-assigned this Feb 1, 2018
@giabmf11
Copy link
Contributor

giabmf11 commented Feb 7, 2018 •
edited
Loading

We have two opitons:

  1. Use the mcrypt extension compatible with PHP 7.2 for the next release since it won't require much development time. Mcrypt isn't being maintained anymore so we should integrate a new library at some point but it will take much more time and introduce BC issues.
  2. Use the libsodium bundled extension inherently supported by PHP 7.2 and refactor our code to integrate the new code.

@piotrekkaminski I sent you an email asking your opinion. Let me know if you want to set up a meeting.

@giabmf11 giabmf11 removed their assignment Feb 7, 2018
This was referenced Feb 17, 2018
Closed
Closed
@buskamuza buskamuza added this to the Magento 2.3.0 milestone Mar 6, 2018
@igrybkov igrybkov self-assigned this Mar 13, 2018
@postadelmaga postadelmaga mentioned this issue Mar 14, 2018
Open
@igrybkov igrybkov mentioned this issue Mar 22, 2018
Merged
4 tasks
@buskamuza
Copy link
Contributor Author

Using mcrypt_compat for 2.3.0.

@buskamuza buskamuza removed this from the Magento 2.3.0 milestone Mar 22, 2018
magento-engcom-team pushed a commit that referenced this issue Mar 26, 2018
@cstergianos
Merge pull request #10 from cstergianos/feature/fix-navigation-menu-o…
60e7d26 
…n-ie11

Update navigation less with display: inline-block
magento-engcom-team added a commit that referenced this issue Mar 30, 2018
@magento-engcom-team
ENGCOM-1196: Async webapi 3 #10
5347b98 
 - Merge Pull Request magento/bulk-api-ce#10 from magento/bulk-api-ce:async-webapi-3
 - Merged commits:
   1. 64ddf04
   2. 3fe794a
   3. 8becb93
   4. fc35895
   5. 5bff58b
   6. d96a19d
   7. 844586e
magento-engcom-team pushed a commit that referenced this issue Mar 30, 2018
@ishakhsuvarov
ENGCOM-1196: Async webapi 3 #10
a4de51b
@buskamuza buskamuza mentioned this issue Apr 12, 2018
Closed
magento-engcom-team added a commit that referenced this issue Jun 6, 2018
@magento-engcom-team
ENGCOM-1871: [Forwardport] Format the javascript code #10 #15833
e7dc28f 
 - Merge Pull Request magento/magento2#15833 from chirag-wagento/magento2:2.3-develop-PR-port-14967
 - Merged commits:
   1. 110ee75
   2. 3994790
   3. 8281b38
magento-engcom-team pushed a commit that referenced this issue Jun 6, 2018
ENGCOM-1871: [Forwardport] Format the javascript code #10 #15833
c5f9fb4
magento-engcom-team pushed a commit that referenced this issue Jun 6, 2018
🔃 [EngCom] Public Pull Requests - 2.3-develop
c62d922 
Accepted Public Pull Requests:
 - magento/magento2#15853: Fixed return type hinting in DocBlocks for Wishlist module (by @rogyar)
 - magento/magento2#15695: Fixed a couple of typos  (by @dverkade)
 - magento/magento2#15833: [Forwardport] Format the javascript code #10 (by @chirag-wagento)
 - magento/magento2#15755: [Forwardport] Error 500 in Module Manager (by @vijay-wagento)
 - magento/magento2#15794: [Forwardport] [Resolved : Styling <select> by changing less variables in Luma theme� (by @hitesh-wagento)
 - magento/magento2#15809: [Forwardport] fix: support multiple minisearch widget instances (by @DanielRuf)
 - magento/magento2#15558: Fixes in catalog component blocks [2.3-develop] (by @mhauri)
 - magento/magento2#15572: [Forwardport] Docblock typo fixes (by @rogyar)
 - magento/magento2#15748: [Forwardport] Prevent multiple add-to-cart initializations in case of ajax loaded product listing (by @vijay-wagento)
 - magento/magento2#15745: [Forwardport] Fix method name (typo) (by @vijay-wagento)
 - magento/magento2#15746: [Forwardport] Resolved : UI Component listing action column outside of screen when... (by @vgelani)
 - magento/magento2#15692: Fix minor issues in ui export converter classes (by @dmytro-ch)
 - magento/magento2#15649: [Forwardport] Fixes in config module (by @mhauri)
 - magento/magento2#15540: fix for Wrong price amount on product page #11717 (by @HirokazuNishi)


Fixed GitHub Issues:
 - magento/magento2#15192: Module Manager module grid is not working Magento 2.2.4 (reported by @jignesh-baldha) has been fixed in magento/magento2#15755 by @vijay-wagento in 2.3-develop branch
   Related commits:
     1. 486f7a7
     2. 1b5d1d1

 - magento/magento2#15608: Styling <select> by changing less variables in Luma theme doesn't work as expected (reported by @denistrator) has been fixed in magento/magento2#15794 by @hitesh-wagento in 2.3-develop branch
   Related commits:
     1. 9fa6425

 - magento/magento2#14153: UI Component listing action column outside of screen when too many columns (reported by @milansimek) has been fixed in magento/magento2#15746 by @vgelani in 2.3-develop branch
   Related commits:
     1. 365bfb4

 - magento/magento2#11717: Wrong price amount on product page (reported by @HirokazuNishi) has been fixed in magento/magento2#15540 by @HirokazuNishi in 2.3-develop branch
   Related commits:
     1. cf05a84
     2. 67a2038
magento-engcom-team pushed a commit that referenced this issue Dec 7, 2018
@speedy008
Merge pull request #10 from magento/2.3-develop
22daf66 
2.3 - Develop
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@igrybkov igrybkov

Labels
backward-incompatible blocker investigation-needed requires-ee-changes
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@igrybkov @buskamuza @giabmf11