-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Success message is not showing when creating invoice & shipment simultaniously #19942
Comments
Hi @Surabhi-Cedcoss. Thank you for your report.
Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:
where @Surabhi-Cedcoss do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?
|
Hi @GovindaSharma. Thank you for working on this issue.
|
@magento-engcom-team give me 2.3-develop instance |
Hi @GovindaSharma. Thank you for your request. I'm working on Magento 2.3-develop instance for you |
Hi @GovindaSharma, here is your Magento instance. |
@GovindaSharma Thank you for verifying the issue. Based on the provided information internal tickets |
Hi @XxXgeoXxX. Thank you for working on this issue.
|
…ce & shipment simultaniously magento#19942
Messages are removed after call method app/code/Magento/Email/Model/Template/Filter.php:blockDirective because all/only shipment email template used construction '{{block}}'. When shipment and invoice created together with send email functionality mesages were added and after that Magento creates block(according templates app/code/Magento/Sales/view/frontend/email/shipment_new.html) by layout functionality(\Magento\Framework\View\LayoutInterface) and it call method initMessages which remove all of them. This does not happen when we only ship order because method add messages called after send email. |
…ing invoice & shipment simultaniously magento#19942
Hi @Surabhi-Cedcoss. Thank you for your report. The fix will be available with the upcoming 2.3.1 release. |
…reating invoice & shipment simultaniously #20142
Hi @Surabhi-Cedcoss. Thank you for your report. The fix will be available with the upcoming 2.2.9 release. |
Accepted Public Pull Requests: - #20391: Success message is not showing when creating invoice & shipment simultaniously #19942 (by @XxXgeoXxX) - #21498: Setting default sorting #21493 (by @Jitheesh) - #21534: correct spelling (by @ravi-chandra3197) - #21536: Fix type hints and replace deprecated method usage (by @avstudnitz) - #21509: Fix: Cart is emptied when enter is pressed after changing product quantity (by @lfluvisotto) - #20528: Fix for #20527 [Admin] Configurable product variations table cell labels wrong position (by @vasilii-b) - #19376: 19276 - Fixed price renderer issue (by @sarfarazbheda) Fixed GitHub Issues: - #21493: Setting default sorting (reported by @iproger) has been fixed in #21498 by @Jitheesh in 2.3-develop branch Related commits: 1. 50647c4 - #21499: Cart is emptied when enter is pressed after changing product quantity (reported by @wojtekn) has been fixed in #21509 by @lfluvisotto in 2.3-develop branch Related commits: 1. 539766f 2. fd3344b - #20527: [Admin] Configurable product variations table cell labels wrong position (reported by @vasilii-b) has been fixed in #20528 by @vasilii-b in 2.3-develop branch Related commits: 1. af11e87 2. ed2a80c 3. d9c962f 4. e8adeca - #19276: Change different product price on selecting different product swatches on category pages (reported by @ankurverma5540) has been fixed in #19376 by @sarfarazbheda in 2.3-develop branch Related commits: 1. 6c5dd94
Preconditions (*)
Steps to reproduce (*)
Expected result (*)
Actual result (*)
The text was updated successfully, but these errors were encountered: