Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

7640: X-Magento-Tags header containing whitespaces causes exception #11767

Merged
merged 1 commit into from
Oct 28, 2017
Merged

7640: X-Magento-Tags header containing whitespaces causes exception #11767

merged 1 commit into from
Oct 28, 2017

Conversation

nmalevanec
Copy link
Contributor

Description

When the header X-Magento-Tags contains whitespaces, an Zend\Http\Header\Exception\InvalidArgumentException is being thrown when the full page cache is enabled. Block IDs can contain whitespaces due to reformatting in layout XML files, because of the 80 character line length limit.

Fixed Issues (if relevant)

  1. X-Magento-Tags header containing whitespaces causes exception #7640: X-Magento-Tags header containing whitespaces causes exception

Manual testing scenarios

  1. Have layout files with block_id arguments that contain whitespaces (see image below)
    1fd0e096-b79e-11e6-9f12-1e300c0cd16c
  2. Enable full page cache
  3. Reload a page
  4. Check page reloaded correctly.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@ishakhsuvarov ishakhsuvarov self-assigned this Oct 27, 2017
@ishakhsuvarov ishakhsuvarov added this to the October 2017 milestone Oct 27, 2017
@ishakhsuvarov ishakhsuvarov added Release Line: 2.2 2.2.x bug report Component: Framework/Cache Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Oct 27, 2017
@nmalevanec nmalevanec changed the title MAGEWTO-7640: X-Magento-Tags header containing whitespaces causes exception 7640: X-Magento-Tags header containing whitespaces causes exception Oct 27, 2017
@okorshenko okorshenko merged commit 026da5a into magento:2.2-develop Oct 28, 2017
okorshenko pushed a commit that referenced this pull request Oct 28, 2017
@ishakhsuvarov
MAGETWO-82887: MAGEWTO-7640: X-Magento-Tags header containing whitesp…
31062ce 
…aces causes exception #11767
okorshenko pushed a commit that referenced this pull request Oct 28, 2017
@ishakhsuvarov
Merge pull request #1637 from magento-engcom/2.2-develop-prs
373bd01 
[EngCom] Public Pull Requests - 2.2-develop
 - MAGETWO-82954: Admin product search - Pressing enter does not submit #4696 #11827
 - MAGETWO-82953: Fix #11581: Reference to wrong / non-existing class #11830
 - MAGETWO-82887: X-Magento-Tags header containing whitespaces causes exception #11767
 - MAGETWO-82886: Improve error reporting for products images import. #11779
 - MAGETWO-82754: Magento setup:install interactive shell #11425
 - MAGETWO-81594: Issue #6924: Unmask exception message during product import #11363
This was referenced Oct 29, 2017
Merged
Merged
@nmalevanec nmalevanec deleted the MAGETWO-7640 branch August 21, 2018 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ishakhsuvarov ishakhsuvarov

Labels
bug report Component: Framework/Cache Progress: accept Release Line: 2.2 Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Milestone
October 2017
Development

Successfully merging this pull request may close these issues.
4 participants
@nmalevanec @magento-team @ishakhsuvarov @okorshenko