Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAGETWO-4711: Improve error reporting for products images import. #11779

Merged
merged 1 commit into from
Oct 28, 2017
Merged

MAGETWO-4711: Improve error reporting for products images import. #11779

merged 1 commit into from
Oct 28, 2017

Conversation

p-bystritsky
Copy link
Contributor

Description

Errors occurred during importing images are logged.

Fixed Issues (if relevant)

  1. Improve error reporting for products images import #4711: Improve error reporting for products images import.

Manual testing scenarios

  1. Create a product, assign at least one image.
  2. Go to System -> Export and export Products.
  3. Delete the image assigned in Step 1.
  4. Go to System -> Import and import Products.
  5. Error message is displayed: "Imported resource (image) could not be downloaded from external resource due to timeout or access permissions..."
  6. File /var/log/exception.log should contain more detailed information about occured error.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@orlangur
Copy link
Contributor

MAGETWO-4711 are issue identifiers in internal JIRA, please do not use them like this :)

@ishakhsuvarov ishakhsuvarov self-assigned this Oct 27, 2017
@ishakhsuvarov ishakhsuvarov added this to the October 2017 milestone Oct 27, 2017
@ishakhsuvarov ishakhsuvarov added Release Line: 2.2 2.2.x bug report Component: ImportExport Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Oct 27, 2017
@okorshenko
Copy link
Contributor

the better branch name is issue-4771
For the commit messages it is better to use the following format:

#4711: Improve error reporting for products images import

  • fixed something

@okorshenko okorshenko merged commit 73272fe into magento:2.2-develop Oct 28, 2017
okorshenko pushed a commit that referenced this pull request Oct 28, 2017
@ishakhsuvarov
MAGETWO-82886: MAGETWO-4711: Improve error reporting for products ima…
266e13f 
…ges import. #11779
okorshenko pushed a commit that referenced this pull request Oct 28, 2017
@ishakhsuvarov
Merge pull request #1637 from magento-engcom/2.2-develop-prs
373bd01 
[EngCom] Public Pull Requests - 2.2-develop
 - MAGETWO-82954: Admin product search - Pressing enter does not submit #4696 #11827
 - MAGETWO-82953: Fix #11581: Reference to wrong / non-existing class #11830
 - MAGETWO-82887: X-Magento-Tags header containing whitespaces causes exception #11767
 - MAGETWO-82886: Improve error reporting for products images import. #11779
 - MAGETWO-82754: Magento setup:install interactive shell #11425
 - MAGETWO-81594: Issue #6924: Unmask exception message during product import #11363
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ishakhsuvarov ishakhsuvarov

Labels
bug report Component: ImportExport Progress: accept Release Line: 2.2 Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Milestone
October 2017
Development

Successfully merging this pull request may close these issues.
5 participants
@p-bystritsky @orlangur @okorshenko @magento-team @ishakhsuvarov