Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed store wise product filter issue #18994

Merged
merged 1 commit into from
Dec 19, 2018
Merged

fixed store wise product filter issue #18994

merged 1 commit into from
Dec 19, 2018

Conversation

shikhamis11
Copy link
Member

Fixed issue - #18374
Unable to get product attribute value for store-view scope type in product collection loaded for a specific store.

Description (*)

Fixed Issues (if relevant)

  1. magento/magento2#<issue_number>: Issue title
  2. ...

Manual testing scenarios (*)

  1. ...
  2. ...

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Sorry, something went wrong.

Fixed issue - #18374
Unable to get product attribute value for store-view scope type in product collection loaded for a specific store.
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Nov 1, 2018

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

Hi @shikhamis11. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@orlangur
Copy link
Contributor

orlangur commented Nov 1, 2018

The change looks quite risky to me, waiting for builds.

@shikhamis11
Copy link
Member Author

@orlangur can you guide me about travis error on build

@orlangur
Copy link
Contributor

orlangur commented Nov 7, 2018

@shikhamis11 does not seem like they are related to your change, will check internal CI also.

@shikhamis11
Copy link
Member Author

@magento-engcom-team give me magento 2.2.3 version instance

@shikhamis11
Copy link
Member Author

@orlangur did you get any clue on travis error on build

@magento-engcom-team magento-engcom-team merged commit 58514a0 into magento:2.3-develop Dec 19, 2018
@magento-engcom-team
Copy link
Contributor

Hi @shikhamis11. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants