Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Forwardport] [Backport] fixed store wise product filter issue #20071

Merged
merged 3 commits into from
Feb 24, 2019
Merged

[Forwardport] [Backport] fixed store wise product filter issue #20071

merged 3 commits into from
Feb 24, 2019

Conversation

shikhamis11
Copy link
Member

Original Pull Request

#19911

Original Pull Request

#18994
Fixed issue - #18374
Unable to get product attribute value for store-view scope type in product collection loaded for a specific store.

Description (*)

Fixed Issues (if relevant)

  1. magento/magento2#<issue_number>: Issue title
  2. ...

Manual testing scenarios (*)

  1. ...
  2. ...

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

shikhamis11 and others added 2 commits January 4, 2019 15:18
Fixed issue - #18374
Unable to get product attribute value for store-view scope type in product collection loaded for a specific store.
@magento-engcom-team
Copy link
Contributor

Hi @shikhamis11. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@sidolov
Copy link
Contributor

sidolov commented Jan 4, 2019

Hi @shikhamis11 , provided changes already merged in scope of #18994
I'm closing this PR as not relevant.
Thank you for the contribution!

@sidolov sidolov closed this Jan 4, 2019
@shikhamis11
Copy link
Member Author

@sidolov yes This is already merged but the changes are not reflecting on 2.3-develop branch.

@shikhamis11 shikhamis11 reopened this Jan 5, 2019
@shikhamis11 shikhamis11 requested a review from sidolov January 5, 2019 18:25
@davidverholen
Copy link
Member

davidverholen commented Jan 6, 2019

there was another commit that has been merged reverting the change. For some reason it's not shown in the pr or in the github file history (it shows for example in phpstorm git file history)
a4b989b

However since the change has already been approved in #18994 I guess this could be merged

@ghost
Copy link

ghost commented Feb 24, 2019

Hi @shikhamis11, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants