Fix get_crds_parameters for ModelContainer (spacetelescope#846)

mairanteodoro · Sep 12, 2023 · 59f1d66 · 59f1d66
1 parent 7fef78d
commit 59f1d66
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 10 deletions.
diff --git a/CHANGES.rst b/CHANGES.rst
@@ -1,7 +1,10 @@
 0.13.0 (unreleased)
 ===================
 
--
+general
+-------
+
+- Fix bug with ``ModelContainer.get_crds_parameters`` being a property not a method [#846]
 
 0.12.0 (2023-08-18)
 ===================

diff --git a/romancal/datamodels/container.py b/romancal/datamodels/container.py
@@ -513,7 +513,6 @@ def crds_observatory(self):
         """
         return "roman"
 
-    @property
     def get_crds_parameters(self):
         """
         Get parameters used by CRDS to select references for this model.

diff --git a/romancal/datamodels/tests/test_datamodels.py b/romancal/datamodels/tests/test_datamodels.py
@@ -359,17 +359,11 @@ def test_get_crds_parameters(n, obj_type, tmp_path, request):
         n, obj_type, tmp_path
     )
 
-    mc = ModelContainer(filepath_list)
-
-    res = mc.get_crds_parameters
-
-    assert isinstance(res, dict)
+    assert isinstance(ModelContainer(filepath_list).get_crds_parameters(), dict)
 
 
 def test_get_crds_parameters_empty():
-    mc = ModelContainer()
-
-    crds_param = mc.get_crds_parameters
+    crds_param = ModelContainer().get_crds_parameters()
 
     assert isinstance(crds_param, dict)
     assert len(crds_param) == 0