Fix get_crds_parameters for ModelContainer

[WilliamJamieson]

Part of the purpose for ModelContainer.get_crds_parameters is so that stpipe can detect that a ModelContainer fits the description of a DataModel and that stpipe can then perform its actions on the ModelContainer object. It does this by checking the ModelContainer against: https://github.com/spacetelescope/stpipe/blob/6f84b52ffcce764a94806a35f5aefd28f3e8f8eb/src/stpipe/datamodel.py#L4-L68
However, this check only checks for the existence of these features: https://github.com/spacetelescope/stpipe/blob/6f84b52ffcce764a94806a35f5aefd28f3e8f8eb/src/stpipe/datamodel.py#L25-L29 not that they follow the template defined in stpipe in general.

Currently, ModelContainer.get_crds_parameters is defined as a property not a method which means it cannot be executed as a function. This is contrary to https://github.com/spacetelescope/stpipe/blob/6f84b52ffcce764a94806a35f5aefd28f3e8f8eb/src/stpipe/datamodel.py#L39-L45 defining it as a method.

This PR drops turning get_crds_parameters into a property.

Checklist

• added entry in CHANGES.rst under the corresponding subsection
• updated relevant tests
• updated relevant documentation
• updated relevant milestone(s)
• added relevant label(s)

[codecov]

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (a530a0e) 76.00% compared to head (af5be2d) 75.99%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #846      +/-   ##
==========================================
- Coverage   76.00%   75.99%   -0.01%     
==========================================
  Files          96       96              
  Lines        5788     5787       -1     
==========================================
- Hits         4399     4398       -1     
  Misses       1389     1389              

Flag	Coverage Δ		*Carryforward flag
nightly	63.93% <ø> (ø)		Carriedforward from a530a0e

*This pull request uses carry forward flags. Click here to find out more.

Files Changed	Coverage Δ
romancal/datamodels/container.py	88.28% <ø> (-0.06%)	⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[nden]

Good catch!

[mairanteodoro]

Thanks for fixing this, @WilliamJamieson!