Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation] Fix project referred to as example #19

Merged
merged 4 commits into from
Oct 19, 2022
Merged

[Documentation] Fix project referred to as example #19

merged 4 commits into from
Oct 19, 2022

Conversation

WeirdAlex03
Copy link
Collaborator

Proposed changes


Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Fixes #18

Types of changes


What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist


Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. This is simply a reminder of what we are going to look for before merging your code.

  • My changeset covers only what is described above (no extraneous changes)
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged downstream

Further comments


If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@emilkovacev emilkovacev changed the base branch from master to submissionProblemScore October 12, 2022 21:15
@WeirdAlex03 WeirdAlex03 deleted the WeirdAlex03/issue18 branch October 12, 2022 21:18
@WeirdAlex03 WeirdAlex03 restored the WeirdAlex03/issue18 branch October 12, 2022 21:22
@WeirdAlex03 WeirdAlex03 reopened this Oct 12, 2022
@emilkovacev emilkovacev changed the base branch from submissionProblemScore to master October 12, 2022 21:24
Copy link
Member

@emilkovacev emilkovacev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than this change, this PR looks good

README.md Show resolved Hide resolved
Copy link
Member

@jessehartloff jessehartloff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the clean up

@jessehartloff jessehartloff merged commit fe8665d into makeopensource:master Oct 19, 2022
@WeirdAlex03 WeirdAlex03 deleted the WeirdAlex03/issue18 branch October 19, 2022 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

[Documentation] Project referred to as "Typescript Example Project" in README, package.json
3 participants