admin user #188
Merged
admin user #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicholasMy
requested changes
Nov 12, 2024
| // delete an admin, only an admin can delete an admin | ||
| export async function deleteAdmin(req: Request, res: Response, next: NextFunction) { | ||
| try { | ||
| let newAdminUserId = req.body.newAdminUserId |
There was a problem hiding this comment.
Use a more appropriate variable name
| return res.status(404).send('Not found') | ||
| } | ||
| await UserService.softDeleteAdmin(newAdminUserId) | ||
| res.status(204).send('User is no longer admin') |
| } | ||
|
|
||
| const isAdmin = await UserService.isAdmin(userId) | ||
| if (!isAdmin!.isAdmin!) return res.status(403).send('unauthorized') |
There was a problem hiding this comment.
Try to be consistent with capitalization on "Unauthorized"
| export async function softDeleteAdmin(id: number) { | ||
| let res = await connect().count({ take: 2, where: { isAdmin: true } }) | ||
| // check if this deletes the last admin | ||
| // there must always be at least 1 admin |
|
fixed it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Implements #168, but instead of adding the user in the config file, the first account created automatically becomes the admin
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any ofthem, don't hesitate to ask. This is simply a reminder of what we are going to look for before merging your code.