Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Imports require whole name for AW functions #246

Closed
Ana06 opened this issue Aug 21, 2020 · 0 comments · Fixed by #274
Closed

Imports require whole name for AW functions #246

Ana06 opened this issue Aug 21, 2020 · 0 comments · Fixed by #274
Labels
enhancement New feature or request question Further information is requested
Milestone
v1.3.0

Comments

@Ana06
Copy link
Member

Ana06 commented Aug 21, 2020

For API calls we support both FindNextFileA and FindNextFile, but for imports we only support FindNextFileA. I think this is confusing. Should we use the generate_api_features helper for imports as well?
@Ana06 Ana06 added enhancement New feature or request migrated question Further information is requested and removed migrated labels Aug 21, 2020
@williballenthin williballenthin added this to the v1.3.0 milestone Aug 27, 2020
williballenthin added a commit that referenced this issue Aug 31, 2020
@williballenthin
tests: add feature tests for #246
5b349c1
williballenthin added a commit that referenced this issue Aug 31, 2020
@williballenthin
features: extract import A/W variants and their base names
090ec46 
closes #246
@williballenthin williballenthin mentioned this issue Aug 31, 2020
Merged
mr-tz pushed a commit that referenced this issue Sep 2, 2020
@williballenthin @mr-tz
tests: add feature tests for #246
2bc1a7c
mr-tz pushed a commit that referenced this issue Sep 2, 2020
@williballenthin @mr-tz
features: extract import A/W variants and their base names
3a5218e 
closes #246
@williballenthin williballenthin mentioned this issue Sep 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Milestone
v1.3.0
Development

Successfully merging a pull request may close this issue.

fix 246 mandiant/capa
2 participants
@williballenthin @Ana06