Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix 246 #274

Merged
merged 6 commits into from
Sep 1, 2020
Merged

fix 246 #274

merged 6 commits into from
Sep 1, 2020

Conversation

williballenthin
Copy link
Collaborator

add helper to generate import features with and without the A/W suffixes.

closes #246 (import features without A/W)

@williballenthin williballenthin added the enhancement New feature or request label Aug 31, 2020
@williballenthin williballenthin added this to the v1.3.0 milestone Aug 31, 2020
Ana06
Ana06 approved these changes Sep 1, 2020
View reviewed changes
Copy link
Member

@Ana06 Ana06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Although, I would aim to unify the implementations of generate_import_features and generate_api_features.

capa/features/extractors/helpers.py Outdated Show resolved Hide resolved
capa/features/extractors/helpers.py Show resolved Hide resolved
mr-tz
mr-tz approved these changes Sep 1, 2020
View reviewed changes
Copy link
Collaborator

@mr-tz mr-tz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see @Ana06's comments, otherwise looks great.

@williballenthin williballenthin merged commit bf90dc0 into master Sep 1, 2020
@williballenthin williballenthin deleted the fix-246 branch September 1, 2020 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ana06 Ana06 Ana06 approved these changes

@mr-tz mr-tz mr-tz approved these changes

@mike-hunhoff mike-hunhoff Awaiting requested review from mike-hunhoff

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.

Imports require whole name for AW functions
3 participants
@williballenthin @Ana06 @mr-tz