Mapbox Maps SDK v10 Integration. #2808

MaximAlien · 2021-02-15T20:12:32Z

Description

PR brings initial Navigation SDK for iOS port to new Mapbox Maps SDK v10.

To see detailed list of changes see changelog.

Fixes #2794.

…gging purposes).

…pbox Maps SDK v10.

…e app.

… to free-drive route line.

…er` protocol.

…ed functionality into separate methods.

…nly for motor transport.

…oints.

…sion instead

…` value precision.

…vigation sources are stored.

Update Mapbox Navigation UI tests.

Update Bench target.

* add delegate methods for waypoint customization, added temporary example usage of delegate methods in example app ViewController, removed NavigationMapViewDelegate conformance from CarPlayNavigationViewController

Remove Xcode 11 builds from Circle CI Remove install dependencies step for Xcode 11

Remove MBNavigationAccuracyAuthorization workaround

Update package manifest to the latest dependencies and configurations Test generic MapboxNavigation-Package target Add codecoverage to an SPM job

Also named some steps.

…irections v2.0.0-alpha.1, Solar v2.2.0 Increased the PodInstall minimum deployment target to iOS 11.0.

Also consolidated example application installation instructions in the contributing guide.

1ec5

Not that I’ve looked this whole PR over, but there’s no time to land a big PR like Friday night. 🎉

ben-xD · 2021-05-21T08:10:45Z

README.md

-### Using Swift Package Manager
-
-The MapboxNavigation framework [does not yet support Swift Package Manager](https://github.com/mapbox/mapbox-navigation-ios/issues/2629) either on the command line or in Xcode. However, if you are building a user interface from scratch, you can [install just the MapboxCoreNavigation framework using SPM](./custom-navigation.md#using-swift-package-manager). 
+The MapboxNavigation framework no longer supports Carthage. However, if you are building a user interface from scratch, you can [install just the MapboxCoreNavigation framework using Carthage](./custom-navigation.md#using-carthage).


If this is true, why is the section ### Using Carthage still present?

There are two separate frameworks, MapboxNavigation does not support Carthage but MapboxCoreNavigation continues to support it.

Im still a bit confused, if MapboxNavigation does not support carthage why does it say:

Using Carthage

To install the MapboxNavigation framework using Carthage v0.35 or above [...]

The readme you’re looking at has been updated a couple times since this PR landed. Here’s the current version from the release-v2.0 branch, where we’re developing v2.0.0. The version on the main branch does still say that MapboxNavigation supports Carthage, because that’s true of v1.x.

Thanks, got it! :) Looks like the new version has a helpful qualifier

MapboxNavigation no longer supports Carthage as of v2.0.0-alpha.1

MaximAlien and others added 30 commits February 12, 2021 12:26

Add initial port to Maps SDK for iOS v10.

c425dff

Add ability to show voice instructions on a map view (mostly for debu…

2c59068

…gging purposes).

Add fix which allows to render route shield icon above route line.

0156f63

Add initial implementation of PassiveLocationManager, which uses Ma…

d7c7194

…pbox Maps SDK v10.

Remove the ability to use custom LocationOptions and refactor sampl…

245346e

…e app.

Add StyledFeature struct, which allows to store information related…

cf050e4

… to free-drive route line.

Add TODO statement for possible method replacement in `LocationProvid…

125d73e

…er` protocol.

Fix build related issues after changing project structure.

2a6b8b3

Add initial implementation of road labeling feature.

78cdb11

Improve current road labeling functionality by extracting commonly us…

180f4b8

…ed functionality into separate methods.

Add filtering functionality which allows to show road classes layer o…

888706d

…nly for motor transport.

Add initial implementation of functionality which allows to show wayp…

00f6e63

…oints.

removed unnecessary comments, removed getOpacity() and used an expres…

0be7e62

…sion instead

Fix build errors.

17e2b49

fix the end of route camera zoom

d98eb05

use mapView bounds for zoom level

30398cb

Add ability to customize route line widths using dictionary.

281ab6a

Pass route line gradient as dictionary instead of data to LineLayer.

a84aca1

Add workaround, which prevents from drawing route line due to `Double…

936b8a0

…` value precision.

Fix inaccurate congestion color rendering.

b486d39

Update changelog and simplify RouteLineWidthByZoomLevel usage.

dac9b7a

Update changelog to match global style.

e1956be

Update license agreement and CLA to use Mapbox Terms of Service.

fc84d56

Rename newly added extensions to accommodate new place where MapboxNa…

e154de5

…vigation sources are stored.

Bring back the ability to override certain road classes.

08305c5

Update changelog.

28ba914

Update MapboxNavigationTests to new Mapbox Maps v10.

70f788d

Merge pull request #8 from mapbox/maxim/fix-mapbox-navigation-tests

8d68dcf

Update Mapbox Navigation UI tests.

Update Bench target and rename mapView to navigationMapView.

c00170d

Merge pull request #25 from mapbox/maxim/update-bench-target

88ab5b6

Update Bench target.

jill-cardamon and others added 12 commits February 19, 2021 16:18

Add delegate methods for waypoint customization (#19)

39cd7a4

* add delegate methods for waypoint customization, added temporary example usage of delegate methods in example app ViewController, removed NavigationMapViewDelegate conformance from CarPlayNavigationViewController

Add .swiftpm to gitignore

89089e1

Upgrade iOS deployment target to v11

c463fd3

Remove Xcode 11 builds from Circle CI Remove install dependencies step for Xcode 11

Removed support for integrating MapboxNavigation with Carthage

547f1cb

Port Obj-C functionality to Swift

5bdbeda

Remove MBNavigationAccuracyAuthorization workaround

Create MapboxNavigation entry in Package.swift

d0876b8

Update package manifest to the latest dependencies and configurations Test generic MapboxNavigation-Package target Add codecoverage to an SPM job

Removed MapboxNavigationTests from CI

55058d7

Also named some steps.

MapboxMaps v10.0.0-beta.13.1, MapboxNavigationNative v42.0.1, MapboxD…

5ac8c9a

…irections v2.0.0-alpha.1, Solar v2.2.0 Increased the PodInstall minimum deployment target to iOS 11.0.

Updated installation instructions for SPM

649535a

Copyedited and updated changelog

97cd8df

Updated system requirements

171f4f2

Also consolidated example application installation instructions in the contributing guide.

Moved SpeechSynthesizerSpy from TestHelper to BenchTests

99e1236

1ec5 mentioned this pull request Feb 20, 2021

Crash playing reroute sound (SPM only) — RouteVoiceController.init(navigationService:speechSynthesizer:accessToken:host:) #2819

Closed

Change CLA date.

05555c0

1ec5 mentioned this pull request Feb 20, 2021

Migrate application targets to SPM #2821

Merged

1ec5 approved these changes Feb 20, 2021

View reviewed changes

1ec5 merged commit 05555c0 into release-v2.0 Feb 20, 2021

1ec5 deleted the mapbox-maps-integration branch February 20, 2021 02:16

This was referenced Feb 20, 2021

Upgrade to Mapbox Maps SDK v10 #2794

Closed

Binary dependencies are unavailable in XCFramework format #2672

Closed

1ec5 mentioned this pull request Mar 2, 2021

Navigator Tiles management #2823

Merged

truburt modified the milestones: v2.0.0 (Public Preview) (iOS), v2.0.0 (Public Preview) Mar 5, 2021

1ec5 mentioned this pull request Mar 13, 2021

Update Transifex configuration after SPM refactor #2864

Merged

ferologics mentioned this pull request Mar 17, 2021

Distribute as XCFramework mapbox/mapbox-gl-native-ios#171

Open

1ec5 mentioned this pull request Mar 17, 2021

Fix MapboxCoreNavigationTests and TestHelper build errors #2874

Merged

1ec5 mentioned this pull request Apr 15, 2021

Reimplement label localization atop Expression #2933

Closed

4 tasks

ben-xD reviewed May 21, 2021

View reviewed changes

1ec5 mentioned this pull request Sep 7, 2021

Reimplement label localization atop Expression (redux) #3330

Merged

1ec5 mentioned this pull request Sep 18, 2021

Unable to hide user location indicator after showing it #3377

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Mapbox Maps SDK v10 Integration. #2808

Mapbox Maps SDK v10 Integration. #2808

MaximAlien commented Feb 15, 2021 •

edited by 1ec5

Loading

1ec5 left a comment

ben-xD May 21, 2021

zugaldia May 21, 2021

ben-xD May 22, 2021

1ec5 May 24, 2021

ben-xD May 24, 2021

Mapbox Maps SDK v10 Integration. #2808

Mapbox Maps SDK v10 Integration. #2808

Conversation

MaximAlien commented Feb 15, 2021 • edited by 1ec5 Loading

Description

1ec5 left a comment

Choose a reason for hiding this comment

ben-xD May 21, 2021

Choose a reason for hiding this comment

zugaldia May 21, 2021

Choose a reason for hiding this comment

ben-xD May 22, 2021

Choose a reason for hiding this comment

Using Carthage

1ec5 May 24, 2021

Choose a reason for hiding this comment

ben-xD May 24, 2021

Choose a reason for hiding this comment

MaximAlien commented Feb 15, 2021 •

edited by 1ec5

Loading