Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing property on web page #293

Closed
jonquet opened this issue Jul 3, 2023 · 1 comment · Fixed by #294
Closed

Missing property on web page #293

jonquet opened this issue Jul 3, 2023 · 1 comment · Fixed by #294

Comments

@jonquet
Copy link

jonquet commented Jul 3, 2023

Go to :
https://mapping-commons.github.io/sssom/

publication_date is referred here:
https://mapping-commons.github.io/sssom/publication_date/

However, the properties is not used by any of the objects described on the page (Mapping, MapppingSet, MappingRegistry, MappingSetReference).
@matentzn matentzn mentioned this issue Jul 4, 2023
Merged
@matentzn
Copy link
Collaborator

matentzn commented Jul 4, 2023

Thank you @jonquet for the report! This will be fixed in #294!

matentzn added a commit that referenced this issue Jul 25, 2023
@matentzn
Fix publication_date (#294)
95ea414 
Resolves #293 

A property (publication_date) was defined in SSSOM, but was not added to
the SSSOM mapping and mapping set data model. Since a very similar
property (mapping_date) was already defined, this change is considered a
bugfix, rather than an added feature.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix publication_date mapping-commons/sssom
2 participants
@matentzn @jonquet