Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix publication_date #294

Merged
merged 1 commit into from
Jul 25, 2023
Merged

Fix publication_date #294

merged 1 commit into from
Jul 25, 2023

Conversation

matentzn
Copy link
Collaborator

@matentzn matentzn commented Jul 4, 2023

Resolves #293

A property (publication_date) was defined in SSSOM, but was not added to the SSSOM mapping and mapping set data model. Since a very similar property (mapping_date) was already defined, this change is considered a bugfix, rather than an added feature.

@matentzn matentzn requested a review from saubin78 July 4, 2023 13:52
@matentzn matentzn requested a review from gouttegd July 25, 2023 13:48
Copy link
Contributor

@gouttegd gouttegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest I am not convinced it makes sense to have a publication_date at the mapping level, anymore than I am convinced it makes sense to have a mapping_date at the mapping set level.

To me it would make more sense to have only a publication_date at the mapping set level (“when the mapping set was published”) and a mapping_date at the mapping level (“when that particular mapping was asserted”).

But you know SSSOM use cases better than I do, so I assume you know what you’re doing. ;)

@matentzn
Copy link
Collaborator Author

The main use case that needs to be covered is mix'n'match for now (merging multiple mapping sets, losing as little information as possible), but yeah, I get your point. I believe we should try to be as liberal as possible and constrain the model more at a local level if I need to.

@matentzn matentzn merged commit 95ea414 into master Jul 25, 2023
@matentzn matentzn deleted the fix-publication-date branch July 25, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing property on web page
2 participants