Update pytest imports for test_special.py #3129
Merged
+20
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qinxuye
added
type: tests
mod: tensor
to be backported
|
I changed some code to make sure the failure of import statement in |
|
Thank you! Sorry for the incomplete fix |
wjsi
added a commit
to wjsi/mars
that referenced
this pull request
Jun 10, 2022
Co-authored-by: Wenjun Si <[email protected]>
wjsi
added a commit
that referenced
this pull request
Jun 10, 2022
* Update pytest imports for test_special.py (#3129) Co-authored-by: Wenjun Si <[email protected]> * Make PyPI user name configurable (#3130) Co-authored-by: RandomY-2 <[email protected]>
qinxuye
added
backported already
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Currently, the file tries to import certain elliptic functions and integrals such as elliprc from both scipy and err_func_integrals.py. However, these functions don't exist in scipy nor err_func_integrals.py if the scipy version is low. So directly importing them causes import errors. We can move these imports to within the test functions, so only if we have correct dependencies then we import them.
Related issue number
Fixes #3128
Check code requirements