Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make PyPI user name configurable #3130

Merged
merged 1 commit into from
Jun 10, 2022
Merged

Make PyPI user name configurable #3130

merged 1 commit into from
Jun 10, 2022
+2 −1

Conversation

wjsi
Copy link
Member

@wjsi wjsi commented Jun 10, 2022

What do these changes do?

Make PyPI user name configurable in secrets of Github Actions.

Related issue number

Fixes #xxxx

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass, see here for how to run them

@wjsi wjsi added mod: deploy to be backported Indicate that the PR need to be backported to stable branch labels Jun 10, 2022
@wjsi wjsi added this to the v0.10.0a1 milestone Jun 10, 2022
@wjsi wjsi requested a review from a team as a code owner June 10, 2022 03:23
qinxuye
qinxuye approved these changes Jun 10, 2022
View reviewed changes
Copy link
Collaborator

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

chaokunyang
chaokunyang approved these changes Jun 10, 2022
View reviewed changes
Copy link
Contributor

@chaokunyang chaokunyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinxuye qinxuye merged commit e872208 into mars-project:master Jun 10, 2022
@wjsi wjsi deleted the deploy/pypi_user branch June 10, 2022 05:59
wjsi added a commit to wjsi/mars that referenced this pull request Jun 10, 2022
@wjsi
Make PyPI user name configurable (mars-project#3130)
b02c1cb
@wjsi wjsi mentioned this pull request Jun 10, 2022
Merged
wjsi added a commit that referenced this pull request Jun 10, 2022
@wjsi @RandomY-2
[BACKPORT] Update pytest imports for test_special.py (#3129) (#3131)
c086c0f 
* Update pytest imports for test_special.py (#3129)

Co-authored-by: Wenjun Si <[email protected]>

* Make PyPI user name configurable (#3130)

Co-authored-by: RandomY-2 <[email protected]>
@qinxuye qinxuye added backported already PR has been backported and removed to be backported Indicate that the PR need to be backported to stable branch labels Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qinxuye qinxuye qinxuye approved these changes

@chaokunyang chaokunyang chaokunyang approved these changes

Assignees
No one assigned
Labels
backported already PR has been backported mod: deploy
Projects
None yet
Milestone
v0.10.0a1
Development

Successfully merging this pull request may close these issues.
3 participants
@wjsi @qinxuye @chaokunyang