Skip to content
This repository has been archived by the owner on Apr 29, 2020. It is now read-only.

Notifications are still sent despite --no-notification #22

Open
bfayers opened this issue Feb 4, 2018 · 6 comments
Open

Notifications are still sent despite --no-notification #22

bfayers opened this issue Feb 4, 2018 · 6 comments

Comments

@bfayers
Copy link

bfayers commented Feb 4, 2018

Notifcations are still sent despite running with -n or --no-notification

@char
Copy link

char commented Feb 21, 2018

When running with -n and -s <path>, "file save" notifications are still sent.

@bfayers
Copy link
Author

bfayers commented Feb 21, 2018

Yes, this is the issue i'm running into.

char pushed a commit to char/deepin-screenshot that referenced this issue Mar 5, 2018
@phocean
Copy link

phocean commented Aug 18, 2018

Please merge the patch, it is very annoying.

@char
Copy link

char commented Aug 18, 2018

@phocean I don't think the deepin team actually check GitHub for pull requests etc.

@hualet
Copy link
Contributor

hualet commented Apr 19, 2019

Sorry for not paid enough attention to the Github since we used Gerrit for code review.
But we're now all working on Github, so can you update your PR @half-cambodian-hacker-man, it's conflicting with other commits.

@mblesel
Copy link

mblesel commented Apr 29, 2019

#60

felixonmars added a commit that referenced this issue Feb 23, 2020
Use a bool everywhere so it works with any other command line options
too.

This addresses #22 and is implemented differently than #60.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants