This repository has been archived by the owner on Apr 29, 2020. It is now read-only.
The -s and -n options can now be used together. fixes#22 #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the -s and -n options together the -n option was ignored before. I added a noNotify argument to the Screenshot::savePathScreenshot and the MainWindow::savePath functions. MainWindow::savePath now sets MainWindow::m_noNotify if the program was called with -n option. Lastly MainWindow::saveSpecificedPath checks m_noNotify before sending a notification.
hualet
reviewed
Apr 30, 2019
| { | ||
| m_noNotify = noNotify; |
There was a problem hiding this comment.
Either that or you pass it to saveSpecificedPath as an additional argument.
I found this way more consistent with how it is done in noNotify() and in my opinion
the class variable that is supposed to control that no notifications are sent should probably
be set correctly when not sending a notification.
But i guess it doesn't really matter that much.
There was a problem hiding this comment.
I mean, savePath is the end of the program, you can just use the function parameter without setting m_noNotify here or just use m_noNotify with it set before savePath called, what do you think?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the -s and -n options together the -n option was ignored
before.
I added a noNotify argument to the Screenshot::savePathScreenshot
and the MainWindow::savePath functions.
MainWindow::savePath now sets MainWindow::m_noNotify if the program
was called with -n option.
Lastly MainWindow::saveSpecificedPath checks m_noNotify before
sending a notification.