hot-fix for the bug of remaining future values #114
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is hot fix of IterativeLoss.
Issue: a bug of IterativeLoss
x_dict.update({value: x_dict[key]})
at line:156 registerkey
-variable's value asvalue
-variable's value. Andkey
-variable remains.key
-variable are sometimes overwritten but sometimes not. For example,AddLoss
copies an input dictionary, and overwrite old one to updated one.key
-variable is not updated. So the effect of reccurence is ignored.Solution