Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hot-fix for the bug of remaining future values #114

Closed
wants to merge 1 commit into from

Conversation

ktaaaki
Copy link
Collaborator

@ktaaaki ktaaaki commented Apr 14, 2020

This is hot fix of IterativeLoss.

Issue: a bug of IterativeLoss

  1. x_dict.update({value: x_dict[key]}) at line:156 register key-variable's value as value-variable's value. And key-variable remains.
  2. At next step, key-variable are sometimes overwritten but sometimes not. For example, AddLoss copies an input dictionary, and overwrite old one to updated one.
  3. the key-variable is not updated. So the effect of reccurence is ignored.

Solution

  • hotfix: delete future variable by replace_dict_keys.
  • raise exception when some variables are overwritten by sampling (now preparing).

@ktaaaki ktaaaki mentioned this pull request May 18, 2020
@ktaaaki ktaaaki closed this May 18, 2020
@ktaaaki ktaaaki deleted the fix/remaining_future_value branch May 25, 2020 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant