Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/unupdated x dict #115

Merged
merged 2 commits into from
May 25, 2020
Merged

Fix/unupdated x dict #115

merged 2 commits into from
May 25, 2020

Conversation

ktaaaki
Copy link
Collaborator

@ktaaaki ktaaaki commented May 18, 2020

This is fix of IterativeLoss. (hot fix #114 is closed.)

Issue: a bug of IterativeLoss

  1. x_dict.update({value: x_dict[key]}) at line:156 register key-variable's value as value-variable's value. And key-variable remains.
  2. At next step, key-variable are sometimes overwritten but sometimes not. For example, AddLoss copies an input dictionary, and overwrite old one to updated one.
  3. the key-variable is not updated. So the effect of reccurence is ignored.

Solution

  • delete future variable by replace_dict_keys at the step of IterativeLoss.
  • get only updated variables from distribution.sample or loss.eval and override them to dictionary of all variables.
  • fix some illegal operations to input dictionary
  • fix wrong input_var of some losses

@masa-su masa-su merged commit 3fa5213 into develop/v0.2.0 May 25, 2020
@masa-su masa-su deleted the fix/unupdated_x_dict branch May 25, 2020 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants