Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

Latest version of closure compiler breaks our closure test suite #2558

Closed
lynnmercier opened this issue Apr 11, 2018 · 0 comments
Closed

Latest version of closure compiler breaks our closure test suite #2558

lynnmercier opened this issue Apr 11, 2018 · 0 comments
Assignees

Comments

@lynnmercier
Copy link
Contributor

The following error message shows up:

Picked up _JAVA_OPTIONS: -Xmx2048m -Xms512m
"LEGACY" is not a valid value for "--module_resolution"
Sample usage: --compilation_level (-O) VAL --externs VAL --js VAL --js_output_file VAL --warning_level (-W) [QUIET | DEFAULT | VERBOSE]
Run with --help for all options and details

acdvorak added a commit that referenced this issue Apr 16, 2018
Fixes #2558

Closure Compiler removed the `LEGACY` value for `--module_resolution`. It now defaults to `BROWSER` instead.

That change was made in google/closure-compiler@c2cd433
@acdvorak acdvorak self-assigned this Apr 16, 2018
acdvorak added a commit that referenced this issue Apr 16, 2018
#2573)

Fixes #2558

Closure Compiler removed the `LEGACY` value for `--module_resolution`. It now defaults to `BROWSER` instead.

That change was made in google/closure-compiler@c2cd433

I ran `npm run test:closure` on this PR and `master` and compared their generated `.closure-tmp` directories. [Beyond Compare](https://www.scootersoftware.com/) found no diffs.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants