This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
chore(package): update google-closure-compiler to version 20180402.0.0 #2573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #2558 Closure Compiler removed the `LEGACY` value for `--module_resolution`. It now defaults to `BROWSER` instead. That change was made in google/closure-compiler@c2cd433
Codecov Report
@@ Coverage Diff @@
## master #2573 +/- ##
=======================================
Coverage 98.76% 98.76%
=======================================
Files 98 98
Lines 4195 4195
Branches 533 533
=======================================
Hits 4143 4143
Misses 52 52Continue to review full report at Codecov.
|
aprigogin
approved these changes
Apr 16, 2018
acdvorak
deleted the
greenkeeper/google-closure-compiler-20180402.0.0-take2
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2558
Closure Compiler removed the
LEGACYvalue for--module_resolution. It now defaults toBROWSERinstead.That change was made in google/closure-compiler@c2cd433
I ran
npm run test:closureon this PR andmasterand compared their generated.closure-tmpdirectories. Beyond Compare found no diffs.