This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
feat(top-app-bar): use mdc-icon-button styles instead of top app bar #4745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the top and bottom padding from the components. Remove the top and bottom margins from the button content. Button content should be center aligned. Use a <button> tag for the chip. BREAKING CHANGE: Update mdc-chip-leading-icon-margin and mdc-chip-trailing-icon-margin mixins signatures to take only left and right margin values.
…dleClick/#handleKeydown. (#4655) BREAKING CHANGE: Dialog `Foundation#handleInteraction` has been split into two methods: `#handleClick` and `#handleKeydown`.
…on group (#4620) BREAKING CHANGE: Replaced adapter methods getParentElement, getSelectedElementIndex with getSelectedSiblingOfItemAtIndex, isSelectableItemAtIndex.
…4697) BREAKING CHANGE: Removed `$mdc-checkbox-ui-pct` sass variable from `MDCCheckbox`
Add Adapter#getInitialFocusEl API. initialFocusEl will be the element passed in to Adapter#trapFocus. This formalizes the a11y-aligned idea of adding focus to an initial element (in #trapFocus) into the API. BREAKING CHANGE: Dialog Adapter#getInitialFocusEl has been added and Adapter#trapFocus first argument is now the initialFocusEl.
…dapters (#4701) BREAKING CHANGE: Replaced adapter methods getParentElement, getSelectedElementIndex with getSelectedSiblingOfItemAtIndex, isSelectableItemAtIndex.
Add MDCChipAdapter#setAttr method. Update screenshot tests with appropriate roles. BREAKING CHANGE: Add the setAttr method to the chip adapter.
Codecov Report
@@ Coverage Diff @@
## develop #4745 +/- ##
==========================================
Coverage ? 98.95%
==========================================
Files ? 129
Lines ? 6332
Branches ? 820
==========================================
Hits ? 6266
Misses ? 65
Partials ? 1Continue to review full report at Codecov.
|
added 2 commits
May 21, 2019 16:11
|
blocked by #4735 |
|
All 693 screenshot tests passed for commit d921653 vs. |
|
no longer blocked |
abhiomkar
approved these changes
May 28, 2019
packages/mdc-top-app-bar/README.md
Outdated
| <a href="#" class="material-icons mdc-top-app-bar__action-item" aria-label="Download">file_download</a> | ||
| <a href="#" class="material-icons mdc-top-app-bar__action-item" aria-label="Print this page">print</a> | ||
| <a href="#" class="material-icons mdc-top-app-bar__action-item" aria-label="Bookmark this page">bookmark</a> | ||
| <a href="#" class="material-icons mdc-top-app-bar__action-item mdc-icon-button" aria-label="Download">file_download</a> |
There was a problem hiding this comment.
Should these be <button> instead?
|
All 693 screenshot tests passed for commit b2e6491 vs. |
|
All 693 screenshot tests passed for commit 8382c2a vs. |
|
All 693 screenshot tests passed for commit 29e9aa4 vs. |
|
All 693 screenshot tests passed for commit 9cb3c27 vs. |
moog16
pushed a commit
that referenced
this pull request
Jun 3, 2019
abhiomkar
pushed a commit
that referenced
this pull request
Jun 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4527