fix(menu): Updated menu to use list's custom event

[abhiomkar]

BREAKING CHANGE: Replaced menu's foundation methods handleClick and handleSelection with handleItemAction to handle list item action (i.e., list's custom event MDCList:action)

Other Changes:

• Removed redundant handleKeyboard and preventDefault logic from menu which is already handled in list's foundation.

Fixes #3481

[kfranqueiro]

Wait until #4144 is merged, then merge this to master separately, so that both appear in the changelog.

[kfranqueiro]

I found an issue with this. Activating a menu item with space now causes the page to scroll, because we're no longer calling preventDefault under any circumstance here (nor in List, aside from the single-selection case).

See also https://github.com/material-components/material-components-web/pull/4144/files#r245053405

[kfranqueiro]

FYI, I think this branch will need to be synced with master and you'll need to test your updated fixture.js against other existing menu screenshot test pages. I think it might break on some of them (e.g. the group-selection test page).

See #4172

[kfranqueiro]

I think this seems reasonable; once #4144 is finished and merged, switch this to base on master so CI will run.

[codecov-io]

Codecov Report

❗ No coverage uploaded for pull request base (master@7ebb2c8). Click here to learn what that means.
The diff coverage is 100%.

@@           Coverage Diff            @@
##             master   #4151   +/-   ##
========================================
  Coverage          ?   98.4%           
========================================
  Files             ?     127           
  Lines             ?    5688           
  Branches          ?     757           
========================================
  Hits              ?    5597           
  Misses            ?      91           
  Partials          ?       0

Impacted Files	Coverage Δ
packages/mdc-menu/foundation.js	83.87% <100%> (ø)
packages/mdc-menu/index.js	100% <100%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ebb2c8...ae0ac81. Read the comment docs.

[googlebot]

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

[googlebot]

CLAs look good, thanks!

[acdvorak]

Just one small nit, otherwise LGTM!

[mdc-web-bot]

🤖 Beep boop!

Screenshot test report 🚦

6 screenshots changed from master on commit 1f5220d:

• https://storage.googleapis.com/mdc-web-screenshot-tests/travis/2019/01/31/16_42_44_260/report/report.html?utm_source=github&utm_medium=pr_comment

Details

3 Changed:

• spec/mdc-menu/classes/menu-selection-group.html

3 Added:

• spec/mdc-menu/classes/baseline.html

[mdc-web-bot]

🤖 Beep boop!

Screenshot test report 🚦

6 screenshots changed from master on commit ae0ac81:

• https://storage.googleapis.com/mdc-web-screenshot-tests/travis/2019/01/31/17_33_22_001/report/report.html?utm_source=github&utm_medium=pr_comment

Details

3 Changed:

• spec/mdc-menu/classes/menu-selection-group.html

3 Added:

• spec/mdc-menu/classes/baseline.html