fix(menu): Add specificity to selection group class #4172
Conversation
|
I think this is referencing the wrong bug? Also, should I be able to repro the bug on the new screenshot test page if I un-nest the selector? The page seems to look identical to me in both cases. |
packages/mdc-menu/mdc-menu.scss
Outdated
|
|
||
| .mdc-menu__selection-group-icon { | ||
| @include mdc-rtl-reflexive-position(left, 16px); | ||
| // Extra specificity required because list-item graphic needed to increase specificity. |
There was a problem hiding this comment.
I don't see .mdc-list-item__graphic anywhere on the screenshot test page. How is this related?
There was a problem hiding this comment.
Nit: Can you update this comment to something like:
// Extra specificity required to override `display` property on `mdc-list-item__graphic`.
|
Here's the report to update goldens from: I can now repro the bug by reverting the CSS change on the branch. |
|
I noticed the checkmark is misaligned in IE but this seems to be a pre-existing issue to this PR, so I logged #4184. |
|
🤖 Beep boop! Screenshot test report 🚦4 screenshots changed from Details |
packages/mdc-menu/mdc-menu.scss
Outdated
|
|
||
| .mdc-menu__selection-group-icon { | ||
| @include mdc-rtl-reflexive-position(left, 16px); | ||
| // Extra specificity required because list-item graphic needed to increase specificity. |
There was a problem hiding this comment.
Nit: Can you update this comment to something like:
// Extra specificity required to override `display` property on `mdc-list-item__graphic`.
|
🤖 Beep boop! Screenshot test report 🚦4 screenshots changed from Details |
…mponents#4172) (cherry picked from commit 1d919ef)
fixes: #4169