Fix: typing_extensions
import causing issues
#188
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Jimmy!
Just a quick fix for something that's causing failures in our
doped
/ShakeNBreak
tests. When importingtyping_extensions
, one gets aModuleNotFoundError
, as it's not an explicit dependency. I flagged this forpymatgen
: materialsproject/pymatgen#3751, fixed in materialsproject/pymatgen#3752, where thefrom typing_extensions import Self
were added toif TYPE_CHECKING:
blocks in the last two releases. I've added this fix here now.Traceback:
GH Actions run link: https://github.com/SMTG-Bham/doped/actions/runs/8951918813/job/24588753603