Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write test-created files to temporary directory, don't pollute test dir #3454

Merged
merged 6 commits into from
Nov 3, 2023
Merged

Write test-created files to temporary directory, don't pollute test dir #3454

merged 6 commits into from
Nov 3, 2023

Conversation

janosh
Copy link
Member

@janosh janosh commented Nov 3, 2023

Also, fix MPScanRelaxSet not using bandgap_tol kwarg.

@janosh janosh added tests Issues with or changes to the pymatgen test suite fix Bug fix PRs dx Developer experience labels Nov 3, 2023
@janosh janosh enabled auto-merge (squash) November 3, 2023 22:37
@janosh janosh merged commit 2ccbfa1 into master Nov 3, 2023
21 checks passed
@janosh janosh deleted the test-files-tmp-dir branch November 3, 2023 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dx Developer experience fix Bug fix PRs tests Issues with or changes to the pymatgen test suite
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@janosh