Use our own, faster arrayCache, compat for Piwik 3 #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very good to have spotted this. Did you manually check for doctrine cache changes to detect this problem or did you detect it while profiling the code? |
|
I noticed it manually a few weeks ago when I was debugging a seg fault. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Piwik 3.0 we require PHP 5.5.9 which causes it to use doctrine/[email protected] . There they added some features to array cache which we do not need like lifetime support and a hit counter etc. I therefore moved the code of the old doctrine array cache implementation into our own arrayCache and no longer extend the doctrine array cache. We are calling the array cache thousands of times in one request and therefore this matters there re performance and memory.
As we are now requiring PHP 5.5.9 we should afterwards release a new major version for this component: 1.0.0
refs matomo-org/matomo#10380