Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let Super User view and edit segments created by other users #6766

Closed
RMastop opened this issue Dec 1, 2014 · 2 comments
Closed

Let Super User view and edit segments created by other users #6766

RMastop opened this issue Dec 1, 2014 · 2 comments
Assignees
@mattab
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Milestone
2.16.0

Comments

@RMastop
Copy link
Contributor

RMastop commented Dec 1, 2014

A Super admin is not able to list all segments available on the Piwik instance via UI.
Since Segments can have a rather large impact on the archiving / performance of a Piwik instance, it would be useful to see what segments are available on the system.
@mattab
Copy link
Member

mattab commented Jan 6, 2015

Hi @RMastop thanks for the suggestion. It would make complete sense to let Super Users view & edit all segments across users.

@mattab mattab added the Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. label Jan 6, 2015
@mattab mattab added this to the Short term milestone Jan 6, 2015
@mattab mattab mentioned this issue Mar 3, 2015
Open
@mattab mattab mentioned this issue Apr 7, 2015
Open
@mattab mattab changed the title Superadmin is not able to list all segments Super Users should be able to list all segments Apr 8, 2015
@mattab mattab added the Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. label Apr 10, 2015
@mattab mattab mentioned this issue Oct 5, 2015
Closed
@mattab mattab self-assigned this Nov 30, 2015
@mattab mattab modified the milestones: 2.15.1, Short term Nov 30, 2015
mattab added a commit that referenced this issue Nov 30, 2015
@mattab
Fixes #6766 Let Super User view and edit segments created by other users
3ac3f88 
As a Super User:

 * I can now see all segments that were created for this website by any other user
  * When a segment was created by another user who is not Super User, the segment appears below a new section "Visible to you because you have Super User access:"
  * Such segments are editable by the Super User
   * The only difference when editing someone else's segment, as a Super User, is that "This segment is visible to [ME]" now says "This segment is visible to [SEGMENT_AUTHOR_USERNAME]"
 * One can now search in the  search bar for a username and see all segments created by this user

For all users:

 * New section "Shared with you:" now lists segments created by a Super User, and marked as "Visible to [All Users]"
   * Before segments  shared with me, looked the same as segments I created, which was confusing
@mattab mattab changed the title Super Users should be able to list all segments Let Super User view and edit segments created by other users Nov 30, 2015
@mattab mattab mentioned this issue Nov 30, 2015
Closed
@mattab
Copy link
Member

mattab commented Nov 30, 2015

PR: #9621

mattab added a commit that referenced this issue Jan 22, 2016
@mattab
Fixes #6766 Let Super User view and edit segments created by other users
a38c0c3 
As a Super User:

 * I can now see all segments that were created for this website by any other user
 * When a segment was created by another user who is not Super User, the segment appears below a new section "Visible to you because you have Super User access:"
 * Such segments are editable by the Super User
 * The only difference when editing someone else's segment, as a Super User, is that "This segment is visible to [ME]" now says "This segment is visible to [SEGMENT_AUTHOR_USERNAME]"
 * One can now search in the  search bar for a username and see all segments created by this user

For all users:

 * New section "Shared with you:" now lists segments created by a Super User, and marked as "Visible to [All Users]"
 * Before segments  shared with me, looked the same as segments I created, which was confusing
@mattab mattab mentioned this issue Jan 22, 2016
Merged
mattab added a commit that referenced this issue Jan 22, 2016
@mattab
UI tests: Segment editor improvements #6766 - Consistent naming in Ma…
a8a835c 
…nage users #9373
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattab mattab

Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Projects
None yet
Milestone
2.16.0
Development

No branches or pull requests
2 participants
@mattab @RMastop