Let Super User view and edit segments created by other users #9621
Conversation
As a Super User: * I can now see all segments that were created for this website by any other user * When a segment was created by another user who is not Super User, the segment appears below a new section "Visible to you because you have Super User access:" * Such segments are editable by the Super User * The only difference when editing someone else's segment, as a Super User, is that "This segment is visible to [ME]" now says "This segment is visible to [SEGMENT_AUTHOR_USERNAME]" * One can now search in the search bar for a username and see all segments created by this user For all users: * New section "Shared with you:" now lists segments created by a Super User, and marked as "Visible to [All Users]" * Before segments shared with me, looked the same as segments I created, which was confusing
mattab
added
not-in-changelog
mattab
changed the title
|
Maybe unrelated to this issue. But imho we should adjust the hover effect when choosing a segment or a website. Both should look the same. Currently a hovered website has a grey background and a hovered segment has a grey border only. Shall we create a new issue for that? Or simply adjust it within this one? |
| } | ||
| segmentationTitle.html(title); | ||
| segmentationTitle.html( "<strong>" + title + "</strong>"); |
There was a problem hiding this comment.
Wouldn't it be better to remove the <strong> here and to add a css class (having font-weight: bold) instead. That would make it easier for custom designs to overwrite the css at that point.
Note: The .text() below does not remove a <strong> (if set before), it simply replaces the text within. Not sure if that is expected behavior.
|
Besides the comment, LGTM |
@sgiehl good point, I never noticed this! could you create a new issue or PR for it? |
As a Super User:
For all users:
Fixes #6766