Introduce new method to check if a segment is valid and available for a given site #23034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… used to generate a query
mneudert
reviewed
Feb 13, 2025
| @@ -586,6 +608,10 @@ public static function getSegmentHash($definition) | |||
| */ | |||
| public function getSelectQuery($select, $from, $where = false, $bind = array(), $orderBy = false, $groupBy = false, $limit = 0, $offset = 0, $forceGroupBy = false) | |||
| { | |||
| if (Development::isEnabled() && !empty($this->missingDatesException)) { | |||
There was a problem hiding this comment.
Hm, it does make sense to not show the warning whenever a segment is created but then also not used.
However, would it also make sense to include a double stacktrace? One for "segment created at" and one for "segment used at"? Depending on the code it may be difficult to find out where it was used, if you only get the information where it was created, unless you know how to reliably reproduce the error and get a breakpoint triggered 🤔
There was a problem hiding this comment.
Good point. I'll change that so it will include both stacktraces
mneudert
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR introduces a new static method to easily allow checking if a segment is actually valid and available.
In addition this PR changes the nasty warning, that is being logged in development mode when a certain segment is created without start and end date.
This warning was actually meant to ensure that start and end dates are set when the segment is used to create a sql query.
Therefor this PR ensures that the warning is now only logged when the object is used to generate a query, rather upon construction.
Review