Introduce new method to check if a segment is valid and available for a given site

core/CronArchive.php

@@ -1003,7 +1003,8 @@ private function invalidateWithSegments(
 
             foreach ($this->segmentArchiving->getAllSegmentsToArchive($idSite) as $segmentDefinition) {
                 // check if the segment is available
-                if (!$this->isSegmentAvailable($segmentDefinition, [$idSite])) {
+                if (!Segment::isAvailable($segmentDefinition, [$idSite])) {
+                    $this->logger->info("Segment '" . $segmentDefinition . "' is not a supported segment");
                     continue;
                 }
 
@@ -1059,24 +1060,6 @@ private function invalidateWithSegments(
         }
     }
 
-
-    /**
-     * check if segments that contain dimensions that don't exist anymore
-     * @param $segmentDefinition
-     * @param $idSites
-     * @return bool
-     */
-    protected function isSegmentAvailable($segmentDefinition, $idSites): bool
-    {
-        try {
-            new Segment($segmentDefinition, $idSites);
-        } catch (\Exception $e) {
-            $this->logger->info("Segment '" . $segmentDefinition . "' is not a supported segment");
-            return false;
-        }
-        return true;
-    }
-
     private function canWeSkipInvalidatingBecauseInvalidationAlreadyInProgress(int $idSite, Period $period, ?Segment $segment = null): bool
     {
         $invalidationsInProgress = $this->model->getInvalidationsInProgress($idSite);

core/CronArchive/SegmentArchiving.php

@@ -94,13 +94,13 @@ public function findSegmentForHash($hash, $idSite)
                 continue;
             }
 
-            try {
-                $segmentObj = new Segment($segment['definition'], [$idSite]);
-            } catch (\Exception $ex) {
+            if (!Segment::isAvailable($segment['definition'], [$idSite])) {
                 $this->logger->debug("Could not process segment {$segment['definition']} for site {$idSite}. Segment should not exist for the site, but does.");
                 continue;
             }
 
+            $segmentObj = new Segment($segment['definition'], [$idSite]);
+
             if ($segmentObj->getHash() == $hash) {
                 return $segment;
             }

core/Segment.php

@@ -99,6 +99,11 @@ class Segment
      */
     private $isSegmentEncoded;
 
+    /**
+     * @var Exception|null
+     */
+    private $missingDatesException = null;
+
     /**
      * Truncate the Segments to 8k
      */
@@ -125,7 +130,6 @@ class Segment
      */
     public function __construct($segmentCondition, $idSites, ?Date $startDate = null, ?Date $endDate = null)
     {
-
         $this->segmentQueryBuilder = StaticContainer::get('Piwik\DataAccess\LogQueryBuilder');
 
         $segmentCondition = trim($segmentCondition ?: '');
@@ -177,6 +181,25 @@ public function __construct($segmentCondition, $idSites, ?Date $startDate = null
         }
     }
 
+    /**
+     * Checks if the provided segmentCondition is valid and available for the given idSites
+     *
+     * @param string $segmentCondition
+     * @params array $idSites
+     * @return bool
+     * @api since Matomo 5.3.0
+     */
+    public static function isAvailable(string $segmentCondition, array $idSites): bool
+    {
+        try {
+            new self($segmentCondition, $idSites);
+        } catch (Exception $e) {
+            return false;
+        }
+
+        return true;
+    }
+
     /**
      * Returns the segment expression.
      * @return SegmentExpression
@@ -335,8 +358,7 @@ private function doesSegmentNeedSubquery($operator, $segmentName)
 
         if ($requiresSubQuery && empty($this->startDate) && empty($this->endDate)) {
             if (Development::isEnabled()) {
-                $e = new Exception();
-                Log::warning("Avoiding segment subquery due to missing start date and/or an end date. Please ensure a start date and/or end date is set when initializing a segment if it's used to build a query. Stacktrace:\n" . $e->getTraceAsString());
+                $this->missingDatesException = new Exception();
             }
             return false;
         }
@@ -586,6 +608,14 @@ public static function getSegmentHash($definition)
      */
     public function getSelectQuery($select, $from, $where = false, $bind = array(), $orderBy = false, $groupBy = false, $limit = 0, $offset = 0, $forceGroupBy = false)
     {
+        if (Development::isEnabled() && !empty($this->missingDatesException)) {
+            $e = new Exception();
+            Log::warning('Avoiding segment subquery due to missing start date and/or an end date. '
+                        . 'Please ensure a start date and/or end date is set when initializing segment: '
+                        . "\n\nCreation stacktrace:\n" . $this->missingDatesException->getTraceAsString()
+                        . "\n\nUsage stacktrace:\n" . $e->getTraceAsString());
+        }
+
         $segmentExpression = $this->segmentExpression;
 
         $limitAndOffset = null;

plugins/SegmentEditor/API.php

@@ -416,9 +416,7 @@ private function filterSegmentsWithDisabledElements(array $segments, $idSite = f
         $idSites = false === $idSite ? [] : [$idSite];
 
         foreach ($segments as $k => $segment) {
-            try {
-                new Segment($segment['definition'], $idSites);
-            } catch (Exception $e) {
+            if (!Segment::isAvailable($segment['definition'], $idSites)) {
                 unset($segments[$k]);
             }
         }