Added feature Custom Dimensions

[tsteur]

refs #9129
fixes #9201 It should only use a request processor of an actually installed plugin
refs #9256 Overlay now show the Segment name

refs #9216 It should now only use a plugin during tracking when it is actually installed

@mattab can you have a look at https://github.com/piwik/plugin-CustomDimensions/blob/master/lang/en.json#L2 and provide useful texts? I did sometimes not know what to write and how to describe. Ideally we have a user guide on piwik.org soon that describes it a bit better and ideally as well the difference between Custom Variables and Custom Dimensions.

@diosmosis I had to make several changes to tests as this https://github.com/piwik/piwik/blob/2.15.1-b1/tests/PHPUnit/Framework/Mock/TestConfig.php#L73 (setting PluginsInstalled = array()) caused a lot of pain. After 1.5 days I made all the tests in core work apart from one test Theme_Home in https://github.com/piwik/piwik/blob/9129_2/tests/UI/specs/Theme_spec.js#L34 that still fails for some reasons but works locally on my installation. Maybe you have an idea? I thought it's maybe due to some TestEnvironment variables that were set in a previous test but this seems to be not the case see https://travis-ci.org/piwik/piwik/jobs/91299185#L1135 .

The changes in the tests will cause some changes to be made in other plugins most likely. Whenever we set configOverride = array('Group' => array('name' => '1')) in PHP or configOverride = {group: {name: 1}} in JS we should instead use configOverride['Group']['name'] = '1' as we otherwise overwrite a previously set PluginsInstalled entry. I could not find a better solution for this as saving the list of installed plugins in TestEnvironment. Usages of configOverride that maybe has to be changed: https://github.com/search?l=&q=configoverride+user%3Apiwik+user%3Apiwikpro&ref=advsearch&type=Code&utf8=%E2%9C%93

This PR also shows that it is not yet possible to build a plugin that is based on an ID (like idDimension, idGoal, ...) and it won't even be easily possible to build this in core since those IDs are needed in API methods. Currently we need to mention $idDimension and $idGoal as parameters in some API methods.

Apart from that:

• I also added segment support for overlays.
• SegmentSelector shows on hover a description of the selected segment now

[tsteur]

Instead of a boolean parameter splitted logic into doSumVisitsMetrics and doSumActionMetrics

[tsteur]

I'm adding WIP + needs review as it would be good to already have a look at it while I add a few more things

[mattab]

Big Pull request, well done @tsteur for another major new feature that will deliver amazing value to users 👍

@mattab can you have a look at https://github.com/piwik/plugin-CustomDimensions/blob/master/lang/en.json#L2 and provide useful texts? I did sometimes not know what to write and how to describe.

Done in matomo-org/plugin-CustomDimensions@2ffaa0d

Ideally we have a user guide on piwik.org soon that describes it a bit better and ideally as well the difference between Custom Variables and Custom Dimensions.

👍 user guide is a must for this powerful feature. will be covered in https://github.com/piwik/plugin-CustomDimensions/issues/3

[mattab]

There is a blocker before this can be merged:

• https://github.com/piwik/plugin-CustomDimensions/issues/12

@tsteur let's take a look tomorrow morning at this one as i'd love to merge PR so @zawadzinski can demo Custom Dimensions!

[mattab]

well done @tsteur ! Next step: publish CustomDimensions plugin on Marketplace