Cache inbound group sessions when decrypting #1566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuroe
reviewed
Aug 30, 2022
MatrixSDK/MXSDKOptions.h
Outdated
| Enable performance optimization where inbound group sessions are cached between decryption of events | ||
| rather than fetched from the store every time. | ||
|
|
||
| @remark The value is set randomly between YES / NO to perform a very basic A/B test |
There was a problem hiding this comment.
Suggested change
| @remark The value is set randomly between YES / NO to perform a very basic A/B test | |
| @remark By default, the value is set randomly between YES / NO to perform a very basic A/B test |
| @@ -20,6 +20,12 @@ | |||
| #import "MXCallHangupEventContent.h" | |||
| #import "MXTaskProfile.h" | |||
|
|
|||
| /** | |||
| Callback function to cancel ongoing duration tracking | |||
There was a problem hiding this comment.
Suggested change
| Callback function to cancel ongoing duration tracking | |
| Callback function to finish ongoing duration tracking |
| @@ -46,6 +52,21 @@ NS_ASSUME_NONNULL_BEGIN | |||
| */ | |||
| - (void)trackDuration:(NSInteger)milliseconds name:(MXTaskProfileName)name units:(NSUInteger)units; | |||
|
|
|||
| /** | |||
| Start tracking the duration of a task and manually cancel when finished using the return handle | |||
There was a problem hiding this comment.
Suggested change
| Start tracking the duration of a task and manually cancel when finished using the return handle | |
| Start tracking the duration of a task and manually stop when finished using the return handle |
Codecov Report
@@ Coverage Diff @@
## develop #1566 +/- ##
===========================================
+ Coverage 45.16% 45.22% +0.05%
===========================================
Files 521 521
Lines 84960 85009 +49
Branches 37510 37534 +24
===========================================
+ Hits 38373 38445 +72
+ Misses 45486 45459 -27
- Partials 1101 1105 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
manuroe
approved these changes
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve megolm event decryption behaviour by caching rather than re-fetching inbounds group sessions from the store. In anecdotal comparison on a single device this leads to 5x - 10x performance improvement.
In order to observe the impact of this improvement more precisely, the following changes are made:
Note that the new performance tracking method conflicts with existing
MXProfilerwhich does the time tracking manually, whereas Sentry handles performance measurements internally. This ambiguity will be resolved in a future PROnce in Sentry, the following dashboards can be constructed from these events: