Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Add button to clear all notification counts, sometimes stuck in historical #2959

Merged
merged 2 commits into from
Nov 28, 2019

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented May 12, 2019

Fixes element-hq/element-web#4586

Signed-off-by: Michael Telatynski [email protected]

Edit by TravisR:
Design: Please review a use case for #3676 too.
image

@turt2live
Copy link
Member

A bit of text to explain what the button does would be nice, also a screenshot/gif of it in action please.

@t3chguy
Copy link
Member Author

t3chguy commented May 12, 2019

/me has no good gif tooling on Windows atm :(

@turt2live
Copy link
Member

a screenshot of the button is fine then, just to show what the placement is and how it looks for future maintainers

@turt2live
Copy link
Member

@t3chguy: it would be good to get this in. I think it now needs review from design, and possibly product. :(

@turt2live
Copy link
Member

Blocking on design (or possibly product) review.

Copy link
Contributor

@nadonomy nadonomy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks!

@turt2live
Copy link
Member

alright, will merge this then get the other button through code review independently.

@turt2live turt2live merged commit c1d5d20 into develop Nov 28, 2019
@jryans jryans removed the blocked label Nov 28, 2019
@Biep
Copy link

Biep commented Dec 3, 2019

A button (or preferably a hotkey) "Go to next room with unread messages" might be more helpful in several use cases. If one just wants to catch up, the proposal here is great - but if one wants to get rid of a stuck notification it might not be (one might want to keep one's valid notifications). And having a hotkey that just moves to the next "task at hand" can be very useful in daily work.
I write this here, because I feel there is a way to factor out the options here in a more orthogonal way - but I haven't found that way yet.

@turt2live
Copy link
Member

@Biep please file an issue rather than commenting on a merged PR. We do not track feedback from closed/merged PRs.

@Biep
Copy link

Biep commented Dec 4, 2019

I already proposed the "Go to next room with unread messages" function somewhere. I wrote this here for in case someone saw a more orthogonal division of functions.

@t3chguy t3chguy deleted the t3chguy/clear_notifications branch May 25, 2020 18:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggestion: Allow manual reset of unread message display (number on the icon).
5 participants