-
-
Notifications
You must be signed in to change notification settings - Fork 827
Add button to clear all notification counts, sometimes stuck in historical #2959
Conversation
…rical Signed-off-by: Michael Telatynski <[email protected]>
A bit of text to explain what the button does would be nice, also a screenshot/gif of it in action please. |
/me has no good gif tooling on Windows atm :( |
a screenshot of the button is fine then, just to show what the placement is and how it looks for future maintainers |
@t3chguy: it would be good to get this in. I think it now needs review from design, and possibly product. :( |
Blocking on design (or possibly product) review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thanks!
alright, will merge this then get the other button through code review independently. |
A button (or preferably a hotkey) "Go to next room with unread messages" might be more helpful in several use cases. If one just wants to catch up, the proposal here is great - but if one wants to get rid of a stuck notification it might not be (one might want to keep one's valid notifications). And having a hotkey that just moves to the next "task at hand" can be very useful in daily work. |
@Biep please file an issue rather than commenting on a merged PR. We do not track feedback from closed/merged PRs. |
I already proposed the "Go to next room with unread messages" function somewhere. I wrote this here for in case someone saw a more orthogonal division of functions. |
Fixes element-hq/element-web#4586
Signed-off-by: Michael Telatynski [email protected]
Edit by TravisR:
![image](https://user-images.githubusercontent.com/1190097/69772129-5a655b00-114c-11ea-81f0-6c2facf32707.png)
Design: Please review a use case for #3676 too.